chore(ts): ignore types in Talk and bring back TS check on CI

.github/workflows/lint-typescript.yml

@@ -4,9 +4,7 @@
 
 name: Lint TypeScript
 
-# FIXME: temporary disable typecheck, until we can perform typecheck without checking Talk
-on:
-  workflow_dispatch:
+on: pull_request
 
 permissions:
   contents: read

src/app/AppConfig.ts

@@ -147,7 +147,7 @@ const appConfigChangeListeners: { [K in AppConfigKey]?: Set<(value: AppConfig[K]
 async function readAppConfigFile(): Promise<Partial<AppConfig>> {
 	try {
 		const content = await readFile(getAppConfigFilePath(), 'utf-8')
-		return JSON.parse(content)
+		return JSON.parse(content) as Partial<AppConfig>
 	} catch (error) {
 		if (error instanceof Error && 'code' in error && error.code !== 'ENOENT') {
 			console.error('Failed to read the application config file', error)

src/certificate/renderer/certificate.utils.ts

@@ -18,8 +18,8 @@ export function parseElectronCertificateFingerprint(fingerprint: string): { algo
 
 	if (isMatched) {
 		return {
-			algorithm: algorithm.toUpperCase(),
-			value: base64ToHex(value),
+			algorithm: algorithm!.toUpperCase(),
+			value: base64ToHex(value!),
 		}
 	}
 	return {

src/global.d.ts

@@ -21,6 +21,11 @@ declare module '*.svg?raw' {
 	export default url
 }
 
+// Ignore types from Talk:
+// No need to type check entire Talk codebase
+// And @talk path is resolved on build time which is problematic fo TS
+declare module '@talk/*'
+
 declare module 'vue-material-design-icons/*.vue' {
 	import type { Component } from 'vue'
 	const component: Component<{ size: number }, Record<string, never>, Record<string, never>, Record<string, never>, Record<string, never>>

src/talk/renderer/TalkWrapper/talk.service.ts

@@ -85,7 +85,7 @@ function createTalkHashStoreAdapter(): TalkHashStoreAdapter {
 	let onDirty: Parameters<TalkHashStoreAdapter['onDirty']>[0]
 	let onUpdate: Parameters<TalkHashStoreAdapter['onUpdate']>[0]
 
-	talkHashStore.$onAction(({ name, after }) => {
+	talkHashStore.$onAction(({ name, after }: { name: string, after: (callback: () => void) => void }) => {
 		if (name !== 'setNextcloudTalkHash') {
 			return
 		}

src/talk/renderer/TitleBar/components/DevMenu.vue

@@ -21,7 +21,7 @@ import IconMessageBadgeOutline from 'vue-material-design-icons/MessageBadgeOutli
 import IconMonitorShare from 'vue-material-design-icons/MonitorShare.vue'
 import { appData } from '../../../../app/AppData.js'
 
-const supportsTestAdminNotification = appData.capabilities?.notifications?.['admin-notifications']?.includes('ocs') && appData.userMetadata?.groups.includes('admin')
+const supportsTestAdminNotification = appData.capabilities?.notifications?.['admin-notifications']?.includes('ocs') && (appData.userMetadata as unknown as ({ groups: string[] } | null))?.groups.includes('admin')
 const supportsTestPushNotification = appData.capabilities?.notifications?.['ocs-endpoints']?.includes('test-push')
 const supportsTestNotification = supportsTestPushNotification || supportsTestAdminNotification
 

src/talk/renderer/UserStatus/components/UserStatusFormCustomMessage.vue

@@ -37,7 +37,7 @@ const { disabled = false } = defineProps<{
 			maxlength="80"
 			:disabled="disabled"
 			:model-value="message ?? ''"
-			@update:model-value="message = $event" />
+			@update:model-value="message = ($event as string)" />
 	</div>
 </template>
 

src/talk/renderer/UserStatus/userStatus.utils.ts

@@ -12,7 +12,7 @@ import { formatDuration, formatDurationFromNow } from '../../../shared/datetime.
 /**
  * List of user status types that user can set
  */
-export const availableUserStatusStatusTypes: UserStatusStatusType[] = (appData.capabilities as unknown)?.user_status?.supports_busy
+export const availableUserStatusStatusTypes: UserStatusStatusType[] = (appData.capabilities as { user_status?: { supports_busy?: boolean } })?.user_status?.supports_busy
 	? ['online', 'away', 'busy', 'dnd', 'invisible']
 	: ['online', 'away', 'dnd', 'invisible']
 

tsconfig.json

@@ -10,7 +10,6 @@
 		"strictNullChecks": true,
 		"paths": {
 			"@global-styles/*": ["resources/server-global-styles/master/*"],
-			"@talk/*": ["spreed/*"],
 		},
 	},
 }