Skip to content

Rename "Note to self" #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ivansss wants to merge 3 commits into from
Closed

Rename "Note to self" #1432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30c5e67
Chnage "Note to self" to "Add to personal notes".
Ivansss Nov 24, 2023
bd7e3f1
Update localizable strings file.
Ivansss Nov 24, 2023
e0e3445
Change confirmation toast text to "Added to personal notes".
Ivansss Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions NextcloudTalk/BaseChatViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,15 +934,15 @@ import QuickLook
if message.isObjectShare() {
NCAPIController.sharedInstance().shareRichObject(message.richObjectFromObjectShare(), inRoom: room.token, for: activeAccount) { error in
if error == nil {
self.view.makeToast(NSLocalizedString("Added note to self", comment: ""), duration: 1.5, position: CSToastPositionCenter)
self.view.makeToast(NSLocalizedString("Added to personal notes", comment: ""), duration: 1.5, position: CSToastPositionCenter)
} else {
self.view.makeToast(NSLocalizedString("An error occurred while adding note", comment: ""), duration: 1.5, position: CSToastPositionCenter)
}
}
} else {
NCAPIController.sharedInstance().sendChatMessage(message.parsedMessage().string, toRoom: room.token, displayName: nil, replyTo: -1, referenceId: nil, silently: false, for: activeAccount) { error in
if error == nil {
self.view.makeToast(NSLocalizedString("Added note to self", comment: ""), duration: 1.5, position: CSToastPositionCenter)
self.view.makeToast(NSLocalizedString("Added to personal notes", comment: ""), duration: 1.5, position: CSToastPositionCenter)
} else {
self.view.makeToast(NSLocalizedString("An error occurred while adding note", comment: ""), duration: 1.5, position: CSToastPositionCenter)
}
Expand Down
2 changes: 1 addition & 1 deletion NextcloudTalk/ChatViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,7 +1513,7 @@ import UIKit
// Note to self
if message.file() == nil, message.poll() == nil, !message.isDeletedMessage(), room.type != kNCRoomTypeNoteToSelf,
NCDatabaseManager.sharedInstance().serverHasTalkCapability(kCapabilityNoteToSelf) {
actions.append(UIAction(title: NSLocalizedString("Note to self", comment: ""), image: .init(systemName: "square.and.pencil")) { _ in
actions.append(UIAction(title: NSLocalizedString("Add to personal notes", comment: ""), image: .init(systemName: "square.and.pencil")) { _ in
self.didPressNoteToSelf(for: message)
})
}
Expand Down
8 changes: 4 additions & 4 deletions NextcloudTalk/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,10 @@
"Add to favorites" = "Add to favorites";

/* No comment provided by engineer. */
"Added note to self" = "Added note to self";
"Add to personal notes" = "Add to personal notes";

/* No comment provided by engineer. */
"Added to personal notes" = "Added to personal notes";

/* No comment provided by engineer. */
"Address" = "Address";
Expand Down Expand Up @@ -1171,9 +1174,6 @@
/* No comment provided by engineer. */
"Not supported" = "Not supported";

/* No comment provided by engineer. */
"Note to self" = "Note to self";

/* No comment provided by engineer. */
"Notifications" = "Notifications";

Expand Down