fix(menu): fix labels for new file actions#8295
Merged
Conversation
Fixes: #8035 Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
to nextcloud/collectives
that referenced
this pull request
Mar 2, 2026
Fixes: #2223 Requires nextcloud/text#8295 Signed-off-by: Jonas <jonas@freesources.org>
3 tasks
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
max-nextcloud
approved these changes
Mar 2, 2026
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
I'm not super happy with the collectives specific code in text - but since it's following the structure used by the files specific code and everything else would be a lot of work this seems like the best option.
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/create_attachment_labels
branch
from
cfd4fb5 to
0c01399
Compare
marcoambrosini
approved these changes
Mar 3, 2026
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/create_attachment_labels
branch
from
8ffec24 to
f1cf770
Compare
Member
Author
|
All remaining failing Cypress tests are unrelated. |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport b75b6f9,0c013990e525dbbda9df5f1b5d0b0e7c678022af,f1cf7702ab2fc00415a71b8719731f98eea73896 to stable32 |
Member
Author
|
/backport b75b6f9 to stable32 |
mejo-
added a commit
to nextcloud/collectives
that referenced
this pull request
Mar 5, 2026
Fixes: #2223 Requires nextcloud/text#8295 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
to nextcloud/collectives
that referenced
this pull request
Mar 5, 2026
Fixes: #2223 Requires nextcloud/text#8295 Signed-off-by: Jonas <jonas@freesources.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8035
Also removes "New text file" from the menu as it doesn't make much sense to create a markdown attachment inside a markdown file in most cases and the option rather confuses users.
Together with nextcloud/collectives#2309 also brings this menu to the editor in Collectives.
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)