Skip to content

fix(menu): fix labels for new file actions #8295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 4 commits into from
Mar 3, 2026
Merged

fix(menu): fix labels for new file actions #8295

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4ec9d0
fix(menu): fix labels for new file actions
mejo- Mar 2, 2026
b75b6f9
fix(menu): use templates from collectives initialState if available
mejo- Mar 2, 2026
0c01399
fix(menu): exclude "New text file" from create file menu options
mejo- Mar 3, 2026
f1cf770
test(cypress): test creating whiteboard attachment
mejo- Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/Menu/ActionAttachmentUpload.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
:svg="template.iconSvgInline" />
<Plus v-else />
</template>
{{ template.actionLabel }}
{{ template.label }}
</NcActionButton>
</template>
</NcActions>
Expand Down Expand Up @@ -116,7 +116,11 @@ export default {
return this.$uploadingState.isUploadingAttachments
},
templates() {
return loadState('files', 'templates', [])
let templates = loadState('collectives', 'templates', [])
if (!templates.length) {
templates = loadState('files', 'templates', [])
}
return templates
},
isUploadDisabled() {
return !this.openData?.hasOwner || !this.networkOnline
Expand Down
Loading