[stable32] fix(viewer): mount text vue instance explicitely #8255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
changed the title
The component configured in the viewer handler is instantiated from the vue module inside the viewer. We want to use our own vue module so create an instance with an import of our own vue and mount it. This fixes warnings in development like $attrs is readonly. Also makes the vue2 dev tools work. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
backport/8233/stable32
branch
from
37522bd to
472f076
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
It is not needed anymore now that the editor is always imported from text. Previously the ViewerComponent was used directly from the viewer which resulted in the editor and thus yjs being imported in two different ways. Signed-off-by: Max <max@nextcloud.com>
Viewer hands a lot of props to the component. We need to pick the ones we actually need and set `inheritAttrs` to false so the others are not added to the dom. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
backport/8233/stable32
branch
from
472f076 to
49c891c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8233
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.