fix: Update EdDSA mapping to OKP in DiscoveryService #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 8037 defines EdDSA public keys as `kty='OKP'`. Current master derives expected `kty` from `alg`; with the wrong mapping it filters out valid OKP keys and fails with “No matching key found.” Signed-off-by: Josh <[email protected]>
1 task
solracsf
approved these changes
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 8037 defines EdDSA public keys as
kty='OKP'. Current master derives expectedktyfromalg; with the wrong mapping it filters out valid OKP keys and fails with “No matching key found.”#1236 almost fixed it, but this should make it work fully now.