Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nextest-runner] add support for custom targets #891

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

sunshowers
Copy link
Member

Pull in target-spec version 2, which implements support for custom targets.

Note that custom targets are not supported in platform overrides, just in --target/CARGO_BUILD_TARGET/build.target.

@sunshowers sunshowers mentioned this pull request Jun 19, 2023
10 tasks
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #891 (704cd7f) into main (1b3a820) will increase coverage by 0.25%.
The diff coverage is 89.02%.

@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
+ Coverage   78.37%   78.62%   +0.25%     
==========================================
  Files          67       67              
  Lines       13673    13949     +276     
==========================================
+ Hits        10716    10968     +252     
- Misses       2957     2981      +24     
Impacted Files Coverage Δ
cargo-nextest/src/dispatch.rs 84.05% <0.00%> (ø)
nextest-runner/src/errors.rs 30.73% <ø> (ø)
nextest-runner/src/cargo_config/target_triple.rs 87.93% <86.47%> (+1.26%) ⬆️
nextest-runner/src/cargo_config/discovery.rs 91.63% <92.30%> (+0.06%) ⬆️
nextest-runner/src/cargo_config/env.rs 96.85% <100.00%> (+0.16%) ⬆️
nextest-runner/src/cargo_config/test_helpers.rs 100.00% <100.00%> (ø)
nextest-runner/src/config/test_helpers.rs 97.56% <100.00%> (+0.06%) ⬆️
nextest-runner/src/list/binary_list.rs 97.42% <100.00%> (+<0.01%) ⬆️
nextest-runner/src/list/test_list.rs 92.10% <100.00%> (+0.01%) ⬆️
nextest-runner/src/target_runner.rs 94.64% <100.00%> (-0.07%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sunshowers sunshowers force-pushed the custom-platforms branch 3 times, most recently from 11c8869 to bacb526 Compare June 19, 2023 21:29
Pull in target-spec version 2, which implements support for custom
targets.

Note that custom targets are not supported in `platform` overrides, just
in `--target`/`CARGO_BUILD_TARGET`/`build.target`.
@sunshowers sunshowers merged commit d2eb797 into nextest-rs:main Jun 20, 2023
@sunshowers sunshowers deleted the custom-platforms branch June 20, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant