Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file() behavior changed with glob on s3 with latest edge release compared to latest stable release #4081

Closed
maxulysse opened this issue Jul 5, 2023 · 3 comments
Milestone

Comments

@maxulysse
Copy link
Contributor

maxulysse commented Jul 5, 2023

Bug report

Expected behavior and actual behavior

file() used to work with globs on s3 buckets, but no longer with the latest edge release.

Issue was noticed while trying to reproduce issues with the nf-core/proteinfold pipeline.

Steps to reproduce the problem

workflow {

ch_input = file("s3://ngi-igenomes/test-data/proteinfold/db/alphafold_mini/small_bfd/*")

println ch_input

}

Program output

export NXF_VER=23.04.2; nextflow run .
N E X T F L O W  ~  version 23.04.2
Launching `./main.nf` [magical_planck] DSL2 - revision: b71c613cc3
[/ngi-igenomes/test-data/proteinfold/db/alphafold_mini/small_bfd/bfd-first_non_consensus_sequences.fasta]
export NXF_VER=23.06.0-edge; nextflow run .
N E X T F L O W  ~  version 23.06.0-edge
Launching `./main.nf` [lonely_wozniak] DSL2 - revision: b71c613cc3
[]

Environment

  • Nextflow version: [?]
  • Java version: [?]
  • Operating system: [macOS, Linux, etc]
  • Bash version: (use the command $SHELL --version)

Additional context

I think we should be using Channel.fromPath() in that case, but wondering if this change of behavior of file() is expected or not.

@drpatelh
Copy link
Contributor

We have just observed the same behaviour again with nf-core/viralrecon as reported in nf-core/viralrecon#385

Works with 23.04.2 and fails with 23.07.0-edge. Be good to know whether this change was intentional or is a bug because it will mean current versions of pipelines will break if a backward-compatible fix isn't pushed to NF.

@pditommaso
Copy link
Member

Too bad, looking into it

@pditommaso
Copy link
Member

Solve via 19a72c4. Thanks for reporting it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants