Update the JSON schema validator library + major refactor #141

nvnieuwk · 2023-12-19T14:20:58Z

A quick draft PR to show the progress that has been done on the migration of JSON schema libraries.

The new library can be found here: https://github.com/harrel56/json-schema

nvnieuwk · 2024-01-20T14:49:35Z

TODOs:

Implement errorMessage keyword
Set up a dialect to validate our schemas
Implement lenient mode again.
...

Improve samplesheet convertor

Co-authored-by: Júlia Mir Pedrol <[email protected]>

Docs v2.0

nvnieuwk added 10 commits December 19, 2023 15:19

added some half working validators

e3f9d57

some small fixes to the error handling

3531eaf

better handle schema exceptions

ed558ae

fix issues with schema + even better errors (wow)

ac81155

more error messages!

690f1a1

no repetition!

633206c

enable format validation

b1ca7c2

files are now validated as an array of inputs

6d77825

remove everit json schema lib and add org.json

cc7434d

small typo fix

3ec9980

nvnieuwk mentioned this pull request Dec 21, 2023

Add array support for samplesheets #128

Merged

nvnieuwk added 8 commits January 18, 2024 14:09

harrel56 part1

e3a1563

add a double error check

ff7c2ba

error messages fixes

685f270

add format validators

155903d

remove print values

8f4f623

add exists keyword

d937d4f

update definitions to defs

14721ad

remove old exists code

ee1aec9

nvnieuwk mentioned this pull request Jan 19, 2024

Add conditional validation in meta-schema #146

Closed

nvnieuwk added 2 commits January 20, 2024 15:09

implement schema keyword

7f7bbed

fix for exists keyword and file-path-pattern

0dba85b

nvnieuwk changed the title ~~Update the JSON schema validator library~~ Update the JSON schema validator library + major refactor Jan 20, 2024

nvnieuwk added 5 commits January 20, 2024 15:54

move isInteger to utils

967373a

cleaning up and fix a typo

c54625f

added uniqueEntries keyword

352bafb

fetch values for error messages

b279de4

implemented errorMessage

a3d3f93

nvnieuwk and others added 28 commits February 15, 2024 13:08

third batch of docs fixes

8dba44e

check for default formats when using anyOf, allOf and oneOf

eadf4f2

wrote the migration docs

59363d5

prettier

2fed4eb

add migration guide to changelog

a250de6

fix migration guide url

25a2445

fix some custom error messages not showing up

1deb52b

Merge branch 'improve-samplesheet-convertor' into docs-v2.0

29ef2ba

Merge pull request #2 from nvnieuwk/improve-samplesheet-convertor

1fccf08

Improve samplesheet convertor

Added deprecated error messages

3cdd4e9

Merge branch 'move-json-validator' into docs-v2.0

7cb0b66

Added deprecated to the docs

949a54b

prettier

9cedf63

Update docs/migration_guide.md

960ee35

Co-authored-by: Júlia Mir Pedrol <[email protected]>

Update docs/nextflow_schema/create_schema.md

a9c1dfc

Co-authored-by: Júlia Mir Pedrol <[email protected]>

Update docs/nextflow_schema/sample_sheet_schema_specification.md

ad7463b

Co-authored-by: Júlia Mir Pedrol <[email protected]>

Update docs/nextflow_schema/sample_sheet_schema_specification.md

f127f1f

Co-authored-by: Júlia Mir Pedrol <[email protected]>

Update docs/nextflow_schema/sample_sheet_schema_specification.md

7520cad

Co-authored-by: Júlia Mir Pedrol <[email protected]>

Update docs/background.md

e163089

Co-authored-by: Júlia Mir Pedrol <[email protected]>

Update docs/samplesheets/examples.md

44a3404

Co-authored-by: Júlia Mir Pedrol <[email protected]>

Update docs/samplesheets/examples.md

e1f343b

Co-authored-by: Júlia Mir Pedrol <[email protected]>

Update docs/samplesheets/fromSamplesheet.md

efa83ce

Co-authored-by: Júlia Mir Pedrol <[email protected]>

Update docs/samplesheets/fromSamplesheet.md

6423d5a

Co-authored-by: Júlia Mir Pedrol <[email protected]>

Update docs/samplesheets/fromSamplesheet.md

674423a

Co-authored-by: Júlia Mir Pedrol <[email protected]>

Update docs/samplesheets/fromSamplesheet.md

ee712e6

Co-authored-by: Júlia Mir Pedrol <[email protected]>

Update docs/samplesheets/fromSamplesheet.md

11666e5

Co-authored-by: Júlia Mir Pedrol <[email protected]>

prettify suggestions

65853ca

Merge pull request #3 from nvnieuwk/docs-v2.0

cf0da97

Docs v2.0

nvnieuwk merged commit 4113068 into nextflow-io:master Feb 19, 2024
3 checks passed

nvnieuwk deleted the move-json-validator branch February 19, 2024 14:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the JSON schema validator library + major refactor #141

Update the JSON schema validator library + major refactor #141

nvnieuwk commented Dec 19, 2023 •

edited

Loading

nvnieuwk commented Jan 20, 2024 •

edited

Loading

Update the JSON schema validator library + major refactor #141

Update the JSON schema validator library + major refactor #141

Conversation

nvnieuwk commented Dec 19, 2023 • edited Loading

nvnieuwk commented Jan 20, 2024 • edited Loading

nvnieuwk commented Dec 19, 2023 •

edited

Loading

nvnieuwk commented Jan 20, 2024 •

edited

Loading