This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
forked from nextflow-io/nf-schema
-
Notifications
You must be signed in to change notification settings - Fork 19
Add samplesheet examples #82
Merged
mirpedrol
merged 7 commits into
nextflow-io:master
from
adamrtalbot:samplesheet-examples-docs
Aug 17, 2023
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c6b31f3
Add samplesheet examples
adamrtalbot 1352539
prettier
adamrtalbot a22a947
samplesheet/examples.md uses clearer example channels
adamrtalbot 8d99ac1
Corrected error in docs/samplesheet/examples
adamrtalbot 302ec09
Added introduction and moved glossary to the top of
adamrtalbot cbabb8e
Apply suggestions from code review
adamrtalbot 3b16ddb
Merge branch 'master' into samplesheet-examples-docs
adamrtalbot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely convinced this is the cleanest and most clear way of representing the channel structure, maybe something like
[meta, fastq_1.fastq, fastq_2.fastq, sample1.bed]
will be more clear for beginners?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to match an input/output declaration for a process. Perhaps I could include both. What does the
.fastq
or.bed
mean in your example?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was to emulate a filename, but yeah this is just a matter of representation. I'm not sure which way is the best or most clear to beginners. (although both should be fine I think)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look now, I've added a clarifying statement about what the channel is and how you would use it.