Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

rename the schema_filename option from fromSamplesheet #91

Merged
merged 3 commits into from
Sep 15, 2023
Merged

rename the schema_filename option from fromSamplesheet #91

merged 3 commits into from
Sep 15, 2023

Conversation

nvnieuwk
Copy link
Collaborator

  1. schema_filename option from fromSamplesheet has been renamed to parameters_schema here to make it more clear to the user that it is used for the parameters schema and not for the samplesheet schema.
  2. Added an additional check to fromSamplesheet that shows an error if the input parameter hasn't been found in the schema

@nvnieuwk nvnieuwk requested a review from ewels September 14, 2023 08:57
ewels
ewels approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shot ourselves in the foot here by including this option at all! As it shouldn't really be needed by 99% of people 👀

Ah well. Change looks good 👍🏻 Especially the error message ⭐️

@ewels ewels merged commit 781511f into nextflow-io:master Sep 15, 2023
3 checks passed
@ewels
Copy link
Member

ewels commented Sep 15, 2023

Might be good to do a minor release soon?

@nvnieuwk
Copy link
Collaborator Author

Might be good to do a minor release soon?

Good idea I'll create a PR for it :)

@nvnieuwk nvnieuwk deleted the change_schema_option branch September 15, 2023 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewels ewels ewels approved these changes

@mirpedrol mirpedrol Awaiting requested review from mirpedrol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvnieuwk @ewels