refactor: remove legacy UI lint and LOC debt - #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the legacy function/complexity suppressions and all seven LOC budgets by splitting existing control logic, chart rendering, navigation, playground examples, and browser scenarios into focused modules. Public component imports, behavior, and appearance are preserved; two settings switches and the confidence slider now have accessible names.
The existing package qualification now imports the affected public controls from an isolated packed consumer, covering the new internal ESM module boundaries. All source files are within 600 lines, tests within 900, functions within 100, and complexity within 12. Accessibility exceptions remain limited to documented SVG, forwarded-label, and scroll/pointer semantics.
Validation:
just checkpassed: formatting, Oxlint, ESLint, supply-chain watchlist, LOC, TypeScript, and packed-consumer qualification.just test-integration: all 19 existing Playwright scenarios passed, including 320/390/768/1440px coverage.Fast review
rvw_a56598d7completed with two Astra medium reviewers reporting no findings. CI passed at69bdcf91a73c6abcc9179754fd0c0bbd235cb16b: https://github.com/nextidemedia/ui/actions/runs/34172557164. No remaining validation gates.