Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to celery 4.0 #196

Closed
wants to merge 1 commit into from
Closed

updated to celery 4.0 #196

wants to merge 1 commit into from

Conversation

dconathan
Copy link
Contributor

as per #159 this updates to celery 4.0

Changes:

  • changed requirements file for docker image (no longer celery==3.1.25)
  • Added a celery.worker_ready function that debug prints to console (basically just mimicking the celery 3 behavior (e.g. sync_worker_2@2affb02ed780 ready.), which is no longer the default)
  • updated celery cli options in next_worker_startup.sh to reflect new new version of celery. (this is what was causing it not to work before)

Note that I didn't mess with any of the options in next.constants - they are transitioning from upper case to lower case but our constants as is will be supported until celery 5 (?). I tried running their "automatically fix it" script and it broke things so I didn't bother... see http://docs.celeryproject.org/en/latest/whatsnew-4.0.html#step-2-update-your-configuration-with-the-new-setting-names

@dconathan dconathan requested a review from erinzm June 30, 2017 19:34
Copy link

@erinzm erinzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

I still have to pull and test locally, but the changes look good

@stsievert
Copy link
Member

Copying some comments from @dconathan over from Slack:

  • I have moved to celery 4. I have noticed getQuery has been pushing .5-1s delays for no apparent reason and I haven't gotten around to debugging it... this could explain that.
  • Tomorrow I'll rebuild with celery 3.1.25 and see if that fixes it...
  • Just reverted back to celery 3.1.25 and getQuery delays are back down to sub .1s range… so almost certainly seeing a slowdown due to celery 4
  • I was wondering about it. Almost all the extra time was “enqueued” time according to the charts.
  • ...
  • I guess there’s one reason not to switch to the latest and greatest

@stsievert stsievert closed this Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants