-
Notifications
You must be signed in to change notification settings - Fork 6
Revises the generic hexaly app #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…automatically, updated readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Improves the generic Python Hexaly app to pass all CLI options directly to the wrapped model and add an unNest
mode for flattening inputs, along with updated documentation.
- Relay every provided argument as
key=value
to the HexalyModeler module - Introduce
unNest=true
to copyinputs/
contents into the CWD before running - Update README and CI scripts to reflect new usage patterns
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
python-hexaly-generic/main.py | Replaced rigid nextmv.Options with generic parse_options , added unnest_directory , and now forwards all args to module.run ; removed the old nextmv.write section |
python-hexaly-generic/README.md | Revised instructions to explain generic option syntax and unNest behavior, and updated CLI examples |
python-hexaly-generic/.gitignore | Added sample model and data files to git ignore |
.nextmv/readme/workflow-configuration.yml | Added new steps (4.sh, 5.sh) to CI configuration and marked them skipped |
.nextmv/readme/python-hexaly-generic/1.sh → 5.sh scripts | Updated and renumbered shell steps to match the new local, push, platform-run, and Docker workflows |
Comments suppressed due to low confidence (2)
python-hexaly-generic/main.py:51
- New logic in
parse_options
andunnest_directory
introduces non-trivial behavior. Adding unit tests for various argument patterns and file-copy scenarios will help prevent regressions.
def parse_options() -> tuple[dict[str, str], bool]:
python-hexaly-generic/main.py:52
- [nitpick] The docstring could be clearer about supported formats (
--key=value
,-key=value
,key=value
, standalone flags) and examples, so maintainers know exactly how CLI flags are interpreted.
"""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we not using nextmv functions like Options, load, and stuff like that? Also the multi-file constructs?
We can't fuse that with the model itself, as it's not written in Python. This is just a thin wrapper. Merely an |
Description
Revises the "generic" hexaly app (
python-hexaly-generic
) by modifying the option handling behavior.Changes
python-hexaly-generic
will now get relayed directly to the wrapped model..hxm
/.lsp
model are freely chosen by the modeler.unNest=true
option forpython-hexaly-generic
when facing models that read from the same directory as they are located in.Resolves ENG-6271