Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 7 support #129

Closed
wants to merge 1 commit into from
Closed

Symfony 7 support #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "library",
"license": "BSD-3-Clause",
"require": {
"php": ">=5.4"
"php": ">=7.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all in but not sure if @JanTvrdik - he was specifically pushing this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully understand.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mostly ready upgrade to PHP 7.1 baseline. I hope to finish that, merge this and release on weekend.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, closing this issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that it is about PHP 7.1, not Symfony 7 support.

},
"require-dev": {
"dibi/dibi": "~3.0 | ~4.0",
Expand All @@ -17,11 +17,11 @@
"nette/tester": "~1.7 | ~2.0",
"nette/utils": "~2.3",
"nextras/dbal": "~1.0 | ~2.0 | ~3.0 | ~4.0 | ~5.0@dev",
"symfony/config": "~2.6 | ~3.0 | ~4.0 | ~5.0 | ~6.0",
"symfony/console": "~2.6 | ~3.0 | ~4.0 | ~5.0 | ~6.0",
"symfony/dependency-injection": "~2.6 | ~3.0 | ~4.0 | ~5.0 | ~6.0",
"symfony/framework-bundle": "~2.6 | ~3.0 | ~4.0 | ~5.0 | ~6.0",
"symfony/http-kernel": "~2.6 | ~3.0 | ~4.0 | ~5.0 | ~6.0",
"symfony/config": "~2.6 | ~3.0 | ~4.0 | ~5.0 | ~6.0 | ~7.0",
"symfony/console": "~2.6 | ~3.0 | ~4.0 | ~5.0 | ~6.0 | ~7.0",
"symfony/dependency-injection": "~2.6 | ~3.0 | ~4.0 | ~5.0 | ~6.0 | ~7.0",
"symfony/framework-bundle": "~2.6 | ~3.0 | ~4.0 | ~5.0 | ~6.0 | ~7.0",
"symfony/http-kernel": "~2.6 | ~3.0 | ~4.0 | ~5.0 | ~6.0 | ~7.0",
"tracy/tracy": "^2.2",
"ext-openssl": "*"
},
Expand Down
2 changes: 1 addition & 1 deletion src/Bridges/SymfonyBundle/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

class Configuration implements ConfigurationInterface
{
public function getConfigTreeBuilder()
public function getConfigTreeBuilder(): TreeBuilder
{
if (!method_exists(TreeBuilder::class, '__construct')) { // Symfony < 4.2.0
$treeBuilder = new TreeBuilder();
Expand Down
2 changes: 1 addition & 1 deletion src/Bridges/SymfonyConsole/ContinueCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ protected function configure()
}


protected function execute(InputInterface $input, OutputInterface $output)
protected function execute(InputInterface $input, OutputInterface $output): int
{
return $this->runMigrations(Runner::MODE_CONTINUE, $this->config);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Bridges/SymfonyConsole/CreateCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ protected function configure()
* @param OutputInterface $output
* @return int
*/
protected function execute(InputInterface $input, OutputInterface $output)
protected function execute(InputInterface $input, OutputInterface $output): int
{
$group = $this->getGroup($input->getArgument('type'));
$path = $this->getPath($group, $input->getArgument('label'));
Expand Down
2 changes: 1 addition & 1 deletion src/Bridges/SymfonyConsole/ResetCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ protected function configure()
}


protected function execute(InputInterface $input, OutputInterface $output)
protected function execute(InputInterface $input, OutputInterface $output): int
{
return $this->runMigrations(Runner::MODE_RESET, $this->config);
}
Expand Down
15 changes: 15 additions & 0 deletions tests/matrix/symfony-bundle/symfony-7.0-php-8.2.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#!/usr/bin/env bash
PHP_VERSION_MIN="80200"
PHP_VERSION_MAX="80299"
COMPOSER_REQUIRE="$COMPOSER_REQUIRE doctrine/dbal:~3.0"
COMPOSER_REQUIRE="$COMPOSER_REQUIRE doctrine/orm:~2.11"
COMPOSER_REQUIRE="$COMPOSER_REQUIRE doctrine/doctrine-bundle:~2.6"
COMPOSER_REQUIRE="$COMPOSER_REQUIRE symfony/config:~7.0"
COMPOSER_REQUIRE="$COMPOSER_REQUIRE symfony/console:~7.0"
COMPOSER_REQUIRE="$COMPOSER_REQUIRE symfony/dependency-injection:~7.0"
COMPOSER_REQUIRE="$COMPOSER_REQUIRE symfony/doctrine-bridge:~7.0"
COMPOSER_REQUIRE="$COMPOSER_REQUIRE symfony/framework-bundle:~7.0"
COMPOSER_REQUIRE="$COMPOSER_REQUIRE symfony/http-kernel:~7.0"
COMPOSER_REQUIRE="$COMPOSER_REQUIRE symfony/yaml:~7.0"
COMPOSER_REQUIRE="$COMPOSER_REQUIRE nette/tester:~2.3"
DBAL='doctrine'