fix(input): input with file type

[wingkwong]

• Closes [BUG] - Input with type file not working on first attempt #2397
• Closes [BUG] - Bug when input type is file. #2311
• Closes Input for file type to upload images single or multiple #2965

📝 Description

• Fixed "uploading file only works on the second attempt" issue
• Revised styles for input[type="file"]
• Revised labelPlacement logic (only support outside / outside-left) for input[type="file"]

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Summary by CodeRabbit

• New Features

  • Introduced support for file type inputs in the input component, enhancing the handling of file uploads.

• Style

  • Added new styles for file inputs, including a cursor pointer and transparent background for better visual feedback.

• Bug Fixes

  • Resolved issues with label placement for file type inputs, ensuring labels are positioned correctly and preventing attribute conflicts.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 17, 2024 10:43am
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 17, 2024 10:43am

[changeset-bot]

🦋 Changeset detected

Latest commit: 7b93380

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@nextui-org/input	Patch
@nextui-org/theme	Patch
@nextui-org/autocomplete	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

The recent updates focus on enhancing input handling for file types within the @nextui-org/input and @nextui-org/theme packages. Key changes include modifications to logic for file input fields to ensure correct behavior on the first attempt, revised label placement for such inputs, and new CSS styles to improve file upload visibility and usability.

Changes

File Path	Change Summary
packages/components/input/src/use-input.ts	Added handling for file type inputs including logic to remove value and onChange attributes, adjust labelPlacement to "outside", and modifications to data attributes based on input type.
packages/core/theme/src/components/input.ts	Introduced new CSS classes for file inputs and removed configuration blocks related to labelPlacement and isMultiline.

Assessment against linked issues

Objective	Addressed	Explanation
#2397: Bug fix to allow file input to work on the first attempt	✅
#2311: Ensure file input value is correctly logged on first click	✅
#2965: Support single or multiple image uploads via file input	✅

The key changes ensure that file inputs function correctly on the first attempt, addressing existing bugs, and introducing usability enhancements required by the linked issues.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6951b1f and 7b93380.

Files selected for processing (3)

• .changeset/rich-berries-switch.md (1 hunks)
• packages/components/input/src/use-input.ts (4 hunks)
• packages/core/theme/src/components/input.ts (2 hunks)

Additional context used

Biome

packages/components/input/src/use-input.ts

[error] 199-199: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 200-200: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

Additional comments not posted (4)

.changeset/rich-berries-switch.md (1)

1-6: The changeset accurately reflects the updates made to the @nextui-org/input and @nextui-org/theme packages. The description succinctly captures the essence of the changes related to the input with file type.

packages/components/input/src/use-input.ts (2)

150-150: The introduction of isFileTypeInput is a clean way to handle specific logic for file inputs. This approach keeps the code modular and easy to maintain.

---

299-306: The use of dataAttr for setting data attributes based on multiple conditions is clear and effective. It ensures that the UI reacts properly to state changes.

packages/core/theme/src/components/input.ts (1)

46-46: Adding specific styles for file inputs (cursor-pointer, bg-transparent, and border-0) enhances the user experience by making the input field more intuitive to interact with.