-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect year in showMonthAndYearPickers with locale #3331
Open
wingkwong
wants to merge
8
commits into
canary
Choose a base branch
from
fix/eng-1019
base: canary
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+152
−18
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7d0d637
fix(date-input): add gregorian year offset to minValue & maxValue
wingkwong 215b4b7
feat(shared-utils): add getGregorianYearOffset
wingkwong cdcf584
fix(calendar): add gregorian year offset to minValue & maxValue
wingkwong fa3b096
feat(changeset): add changeset
wingkwong 39267f2
fix(system): remove defaultDates.minDate and defaultDates.maxDate
wingkwong b036e41
fix(calendar): add missing import
wingkwong 336a4ff
feat(date-picker): add test
wingkwong 5c111b9
feat(calendar): add test
wingkwong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
"@nextui-org/calendar": patch | ||
"@nextui-org/date-input": patch | ||
"@nextui-org/system": patch | ||
"@nextui-org/shared-utils": patch | ||
--- | ||
|
||
Fixed incorrect year in `showMonthAndYearPickers` with different locales |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
export function getGregorianYearOffset(identifier: string): number { | ||
switch (identifier) { | ||
case "buddhist": | ||
return 543; | ||
case "ethiopic": | ||
case "ethioaa": | ||
return -8; | ||
case "coptic": | ||
return -284; | ||
case "hebrew": | ||
return 3760; | ||
case "indian": | ||
return -78; | ||
case "islamic-civil": | ||
case "islamic-tbla": | ||
case "islamic-umalqura": | ||
return -579; | ||
case "persian": | ||
return 622; | ||
case "roc": | ||
case "japanese": | ||
case "gregory": | ||
default: | ||
return 0; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Redundant Case Clauses
The cases for 'roc', 'japanese', and 'gregory' are redundant since they fall into the default case which returns
0
. Removing these will simplify the switch statement without affecting functionality.Committable suggestion
Tools
Biome