-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(user): avatar icon not shown in user #3371
Closed
abhinandan-verma
wants to merge
8
commits into
nextui-org:canary
from
abhinandan-verma:fix/avatar-icon-not-shown-in-user
Closed
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
af37f80
fix(user): avatar icon not shown in user component
abhinandan-verma e6ea208
fix(user): avatar icon not shown in user component
abhinandan-verma ac5d9b6
fix(user): avatar icon not shown in user component
abhinandan-verma a49d8e3
fix(user): avatar icon not shown in user component
abhinandan-verma fce1018
Delete .changeset/few-stingrays-lay.md
abhinandan-verma 7824fd7
fix(user): avatar icon not shown in user component
abhinandan-verma da2cbb7
fix(user): avatar icon not shown in user component
abhinandan-verma 90c4bdc
fix(user): avatar icon not shown in user component
abhinandan-verma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@nextui-org/user": patch | ||
--- | ||
|
||
Removed `name` from `avatarProps` in `use-user.ts` (#3369) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@nextui-org/user": patch | ||
--- | ||
|
||
Removed `name` from `avatarProps` in `use-user.ts` (#3369) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test case doesn't match with the title. also the issue is that the attribute
name
in User component got forwarded to Avatar component. in your test case, it shouldn't havename
inavatarProps
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I Will try again to make it perfect.