Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(user): avatar icon not shown in user #3371

Closed
wants to merge 8 commits into from
Closed

fix(user): avatar icon not shown in user #3371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
af37f80
fix(user): avatar icon not shown in user component
abhinandan-verma Jun 30, 2024
e6ea208
fix(user): avatar icon not shown in user component
abhinandan-verma Jun 30, 2024
ac5d9b6
fix(user): avatar icon not shown in user component
abhinandan-verma Jun 30, 2024
a49d8e3
fix(user): avatar icon not shown in user component
abhinandan-verma Jun 30, 2024
fce1018
Delete .changeset/few-stingrays-lay.md
abhinandan-verma Jun 30, 2024
7824fd7
fix(user): avatar icon not shown in user component
abhinandan-verma Jun 30, 2024
da2cbb7
fix(user): avatar icon not shown in user component
abhinandan-verma Jul 1, 2024
90c4bdc
fix(user): avatar icon not shown in user component
abhinandan-verma Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fair-zebras-fetch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nextui-org/user": patch
---

Removed `name` from `avatarProps` in `use-user.ts` (#3369)
6 changes: 3 additions & 3 deletions packages/components/user/__tests__/user.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ describe("User", () => {
});

it("should have the passed name", () => {
const {container} = render(<User name="Test" />);
const name = container.querySelector("span");
const {getByText} = render(<User name="Test" />);
const nameElement = getByText("Test");

expect(name).toHaveTextContent("Test");
expect(nameElement).toBeInTheDocument();
});

it("should have the passed description", () => {
Expand Down
1 change: 0 additions & 1 deletion packages/components/user/src/use-user.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ export function useUser(props: UseUserProps) {

const avatarProps = {
isFocusable: false,
name: typeof name === "string" ? name : undefined,
...userAvatarProps,
};

Expand Down