Use uploaded brand logo assets in design system previews#6056
Open
mturac wants to merge 1 commit into
Open
Conversation
2 tasks
Contributor
|
Thanks — the regression scope is clear from the summary and linked issue. Two quick housekeeping items before pool review scopes this cleanly:
Also marking this for QA validation because this changes the brand preview/logo adoption path that users see. Nothing needed from you right now — we’ll follow up here once it reaches QA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5913
Surface area
Validation
pnpm --dir apps/daemon exec vitest run -c vitest.config.ts tests/logo-priority.test.ts tests/brand-extraction-engine.test.tspnpm --filter @open-design/daemon typecheckgit diff --check