Skip to content

Use uploaded brand logo assets in design system previews#6056

Open
mturac wants to merge 1 commit into
nexu-io:mainfrom
mturac:izon/open-design-5913-brand-assets
Open

Use uploaded brand logo assets in design system previews#6056
mturac wants to merge 1 commit into
nexu-io:mainfrom
mturac:izon/open-design-5913-brand-assets

Conversation

@mturac

@mturac mturac commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • mirror logo-like uploads from project assets into logos before preview and finalize adoption
  • prefer real wordmark/logotype names when filling an empty logo slot while keeping explicit logo path resolution extension-first
  • add regression coverage for preview/finalize mirroring, dedupe, collision bounds, and ranking

Fixes #5913

Surface area

  • Brand extraction previews
  • Logo asset adoption and finalization
  • Logo ranking regression coverage
  • Database or migrations
  • Public API contract changes

Validation

  • Regression coverage verifies empty-logo adoption now prefers wordmark/logotype-like filenames when supported extensions tie.
  • pnpm --dir apps/daemon exec vitest run -c vitest.config.ts tests/logo-priority.test.ts tests/brand-extraction-engine.test.ts
  • pnpm --filter @open-design/daemon typecheck
  • git diff --check

@lefarcen
lefarcen requested a review from PerishCode July 24, 2026 11:28
@lefarcen lefarcen added size/L PR changes 300-700 lines risk/high High risk: apps/desktop, daemon, auth, migration, workflows, package deps type/bugfix Bug fix labels Jul 24, 2026
@lefarcen lefarcen added the needs-validation Runtime change detected; needs human or /explore agent validation. label Jul 24, 2026
@lefarcen

Copy link
Copy Markdown
Contributor

Thanks — the regression scope is clear from the summary and linked issue.

Two quick housekeeping items before pool review scopes this cleanly:

  • please add the Surface area checklist
  • please add a short Validation section with what you actually ran / verified

Also marking this for QA validation because this changes the brand preview/logo adoption path that users see. Nothing needed from you right now — we’ll follow up here once it reaches QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-validation Runtime change detected; needs human or /explore agent validation. risk/high High risk: apps/desktop, daemon, auth, migration, workflows, package deps size/L PR changes 300-700 lines type/bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Creating a new Design System ignores the brand and only generates the default design system

2 participants