Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor hotkey handling out of SPA. #130

Open
1 of 10 tasks
Tracked by #106
, #141
...
nexushoratio opened this issue Sep 13, 2023 · 0 comments
Open
1 of 10 tasks
Tracked by #106
, #141
...

Factor hotkey handling out of SPA. #130

nexushoratio opened this issue Sep 13, 2023 · 0 comments
Labels
cleanup This doesn't seem right, refactor, etc library For libraries linkedin-tool For the LinkedIn Tool userscript

Comments

@nexushoratio
Copy link
Owner

nexushoratio commented Sep 13, 2023 •
edited
Loading

Let's have SPA just focus on selecting the Page.

Page would also lose hotkey knowledge, and go into a details support class similar to SPADetails. LinkedIn might be a place to put some info, but really, I would expect hotkeys to be a common feature of at least anything I write, so should be separate. But come up with some sort of API for SPA to use to interact with registered components. Right now that would only be say, hot key and click-on support. But maybe others in the future.

Pages should still register an element to watch for while the page rebuilds. Then call registered features like turning hotkeys on/off, click handling, anything else that currently goes into _refresh.

Also this means that everything for building the info view should be factored out as well and controlled by SPADetails subclasses.
@nexushoratio nexushoratio added cleanup This doesn't seem right, refactor, etc linkedin-tool For the LinkedIn Tool userscript labels Sep 13, 2023
@nexushoratio nexushoratio mentioned this issue Sep 14, 2023
Open
4 tasks
@nexushoratio nexushoratio mentioned this issue Sep 23, 2023
Closed
@nexushoratio nexushoratio removed the linkedin-tool For the LinkedIn Tool userscript label Sep 24, 2023
@nexushoratio nexushoratio changed the title Factor hotkey handling and click-on out of SPA. Factor hotkey handling out of SPA. Oct 5, 2023
@nexushoratio nexushoratio self-assigned this Oct 5, 2023
@nexushoratio nexushoratio mentioned this issue Oct 5, 2023
Open
14 tasks
nexushoratio pushed a commit that referenced this issue Oct 5, 2023
A rough initial implmentation of how a Service might work with SPA.
db4c3b7 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 6, 2023
Update JSDoc for addService.
81cb2ec 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 7, 2023
JSDoc: Normalize most constructor() comments.
1df6c34 
At least those for Page subclasses, and a few others.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 8, 2023
Have addService() return the instance it just created.
3456344 
This way the caller can track it.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 8, 2023
Track the DummyService that was created.
6826ba2 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 8, 2023
Enhance Page to take a PageDetails upon construction.
70fe510 
With #private variables, we need to move away from having code in the base
class that can use overrides in the subclasses.  Instead, we will need to pass
them in through the constructor or other mechanisms.  Here, we are adding some
items similar to what we already use, but can do differently.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 8, 2023
Have Feed start using the new PageDetails argument.
3d64410 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 8, 2023
Rename pageReadyCSS to pageReadySelector.
734ecf1 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 8, 2023
Wait until the page settles before activating services.
9de38f8 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 8, 2023
Update comment about moving the call to _refresh().
0f7bc1e 
it is a race between two bugs to see which will get fixed first!

Issues #130, #150.

␄
nexushoratio pushed a commit that referenced this issue Oct 8, 2023
Change SPA to register a class, not an instance.
6d4b080 
This will allow us to move eventually remove the `start()` method.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 8, 2023
Have all Page subclasses use a PageDetails.
b49372e 
Issues #130, #149.

␄
nexushoratio pushed a commit that referenced this issue Oct 9, 2023
Fix typo in comment.
f5fb4fd 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 9, 2023
Have Page use the pathname passed in via details.
8cbf6ce 
Issues #130, #149.

␄
nexushoratio pushed a commit that referenced this issue Oct 9, 2023
Allow addService() to pass arguments during construction.
28f33dd 
Issues #130, #149.

␄
nexushoratio pushed a commit that referenced this issue Oct 9, 2023
Remove the start() method from Service.
52722cc 
We are going to remove `start()` from `Page` soon, so it makes no sense to
have a new use of it.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 10, 2023
Create a VMKeyboardService.
9dabee6 
Not yet fully enabled, though does listen for 'focus' events and can handle
arbitrary conditions like 'inDialog'.

Right now, handling of these kinds of events is global.

This implementation will also allow each `Page` to register more than one set
of shortcuts.  In theory, shortcuts common to different views could be shared,
though may be difficult depending on how much information they would need to
share between them.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 10, 2023
Add a Logger.clear() method.
132cb64 
I have wanted this so many times!

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 10, 2023
Create DebugKeys as an optional set of shortcuts for Global.
9b90c3a 
No-op as `VMKeyboardService` does not yet actively enable keys.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 10, 2023
Missed a place where we need to loop over values in a Map.
25c389a 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 12, 2023
Rename Scrollers's element tracking attribute.
f299fcb 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 12, 2023
Turn off some logging by default.
23987fe 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 19, 2023
Split the lit-instructions CSS class into two.
ce013b3 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 19, 2023
Move the info widget styling to CSS classes.
c2cd1b0 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 21, 2023
Use a local variable for tracking the infowidget container element.
44de03b 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 21, 2023
Add a dismiss button to the header of the new info widget.
93e44c9 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 24, 2023
Install event listeners for the new info widget.
9aa14a7 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 24, 2023
Install tabs in the new info widget.
151954d 
Also populated it with a couple of easy to handle tabs.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 25, 2023
Factor out generation of the name and instruction elements.
5192006 
The function was getting too long.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 25, 2023
Add hotkey navigation for inside the new info view.
28065db 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 25, 2023
Rename some event handlers.
881909b 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 25, 2023
Prefer new info view in dev mode.
7276e64 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 25, 2023
Give Service a *shortName* property.
bc7a662 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 25, 2023
Improve list of shortcut in VMKeyboardService.
2de1c49 
Expose the list via a getter and update it when instance are removed.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 26, 2023
Expose active status of a VMKeyboardService instance.
62666aa 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 27, 2023
Export VMKeyboardService.#services as a getter.
a8f7586 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 27, 2023
Create an empty shortcuts tab for the new info view.
73b8ee8 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 27, 2023
Hook in building shortcut table each time the info view is opened.
ac0ce91 
Does not yet actually build anything, just logs.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 28, 2023
Factor some reusable code out of InfoWidget into a base class.
0bd15ae 
Other rendering widgets can also use this base, but will require a bit more
work.  This is essentially a distilaltion of previous implementations.

More imporantly, this can be used for the forthcoming accordion widget.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 28, 2023
Minor tweak to JSDoc wording.
de33510 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 28, 2023
Enhance TabbedUI to take an HTML element as well as a string.
2141ae4 
This will make it easier for a tab to be another widget.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 28, 2023
Implement Widget.clear().
8740080 
Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 28, 2023
Create a simple AccordionTableWidget.
b8b08c1 
Does not do much yet, just a base to build on.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 28, 2023
Start populating the new table with shortcuts.
0c173c1 
Very raw, no styling yet.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 28, 2023
Add a VMKeyboardService to all Pages.
fa3be89 
They still do nothing, but it will at least allow the new info view to have
content.

Issue #130.

␄
nexushoratio pushed a commit that referenced this issue Oct 29, 2023
Move *parseSeq* from SPA to VMKeyboardService.
8b95f09 
Both currently use `VM.shortcut` facilities, so it makes sense to put them
together.

Issue #130.

␄
@nexushoratio nexushoratio added linkedin-tool For the LinkedIn Tool userscript library For libraries labels Oct 30, 2023
@nexushoratio nexushoratio removed their assignment Oct 30, 2023
nexushoratio pushed a commit that referenced this issue Nov 4, 2023
Bump lib/base to version 22.
a54a35a 
Use new *simpleParseWords()* function and retire similar static `SPA` method.

Issues #130, #180.

␄
nexushoratio pushed a commit that referenced this issue Nov 7, 2023
Retire the DummyService.
22df9d7 
No longer needed as we have real ones to test with.

Issue #130.

␄
@nexushoratio nexushoratio mentioned this issue Nov 11, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup This doesn't seem right, refactor, etc library For libraries linkedin-tool For the LinkedIn Tool userscript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nexushoratio