Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of checkIfExists for params paths #312

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

JoseEspinosa
Copy link
Member

Get rid of checkIfExists for params paths since this is already validated by the nf-validation plugin

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).

@github-actions
Copy link

github-actions bot commented Jul 19, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c999339

+| ✅ 155 tests passed       |+
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.1.0
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • system_exit - System.exit in WorkflowAtacseq.groovy: System.exit(1) [line 18]
  • system_exit - System.exit in WorkflowAtacseq.groovy: System.exit(1) [line 31]

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-07-19 17:09:31

Copy link
Contributor

@bjlang bjlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JoseEspinosa JoseEspinosa merged commit 143f02c into nf-core:dev Jul 19, 2023
13 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants