Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging template 2.12 #348

Merged
merged 11 commits into from
Feb 1, 2024
Merged

Merging template 2.12 #348

merged 11 commits into from
Feb 1, 2024

Conversation

JoseEspinosa
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7d1e034

+| ✅ 181 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowAtacseq.groovy: Optionally add in-text citation tools to this list.
  • system_exit - System.exit in WorkflowAtacseq.groovy: System.exit(1) [line 22]
  • system_exit - System.exit in WorkflowAtacseq.groovy: System.exit(1) [line 35]

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.bamtools_filter_pe_config
  • nextflow_config - Config default ignored: params.bamtools_filter_se_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-01 22:03:12

@JoseEspinosa
Copy link
Member Author

@nf-core-bot fix linting

CarsonJM
CarsonJM reviewed Feb 1, 2024
View reviewed changes
.devcontainer/devcontainer.json Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this syntax pass tests (I'm referring to the commas causing linting to fail) in future updates? I've seen several pipelines just remove the comma so that the tests pass.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know that this was the cause thanks!

@JoseEspinosa JoseEspinosa merged commit a4b97cb into nf-core:dev Feb 1, 2024
11 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarsonJM CarsonJM CarsonJM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoseEspinosa @CarsonJM @nf-core-bot