-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch update: copy max_* params to resourcelimit directive #758
Conversation
Co-authored-by: Simon Pearce <[email protected]>
Go for it for my configs! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the uppmax profile should have the full resource limits map set. I have a feeling inheritance doesn't apply here.
Co-authored-by: Mahesh Binzer-Panchal <[email protected]>
…e-configs into batch-resourcelimit-update
…cks in SAGE config and replace with resourceLimits
@HaidYi I've had to tweak your St. Jude profile slightly to make the tests pass (not sure why it didn't come up in your original PR), it bascially uses a Groovy call to resolve the TMPDIR path, because otherwise Nextflow thinks it's it's own variable. I hope that's OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
This is in preparation for the new nf-core/tools 3.0.0 release, that deprecates the
check_max()
function +max_()
params with the native Nextflow 'resourceLimit' directive.I have done an initial pass using a bash script, but there are some remaining profiles that need to be addressed.
This will need to be dealt with manually.
To be adressed in follow up PR
Scripts and log:
batch-resourcelimit-scripts.zip