-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hit selection module #191
hit selection module #191
Conversation
|
cb7fd15
to
f66fa7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small remarks, looks otherwise good so I'll directly approve :)
|
||
min <- 0 | ||
max <- ${hit_selection_iteration_nb} | ||
steps <- max - min |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If min is always 0, this is not really necessary
steps <- max - min | ||
hit.genes.last <- NULL | ||
final_results <- list() # Initialize as an empty list | ||
for(i in 1:steps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can accordingly be changed as well
Co-authored-by: WackerO <[email protected]>
Co-authored-by: WackerO <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I know this PR is already merged but I am leaving a couple of comments which I think should be fixed in the docs 🙂
- ([MAGeCK test](https://sourceforge.net/p/mageck/wiki/usage/#test)) | ||
- ([MAGeCK mle](https://sourceforge.net/p/mageck/wiki/Home/#mle)) | ||
- ([BAGEL2](https://github.com/hart-lab/bagel)) | ||
- ([DrugZ](https://github.com/hart-lab/drugz)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this go under point 5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually no it's also a gene essentiality analysis but only on drug treated cell lines. It does something similar to MAGeCK MLE
## :warning: The hitselection algorithm is for the moment developed only for KO screens and requires the library to map to genes with an Homosapiens EntrezID. | ||
|
||
## :warning: Please be advised that the Hitselection algorithm is time intensive and will make the pipeline run longer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To show a formatted warning box on the webside the notation is the following:
> [!WARNING]
> The hitselection algorithm is for the moment developed only for KO screens and requires the library to map to genes with an Homosapiens EntrezID.
> [!WARNING]
Please be advised that the Hitselection algorithm is time intensive and will make the pipeline run longer
This PR aims to add a new feature : hit selection. The aim would be to run an algorithm on found gene essentials and determine a p-value cutoff based on the degree of protein protein interaction network.
nf-core/crisprseq runs MAGeCK RRA, MAGeCK MLE, BAGEL2 or DRUGZ so I've plugged HITSELECTION after each of these processes and added a parameter giving the user the option to run hitselection or not.
It bases itself on an R script in the module hitselection.nf and on 2 assets : hgnc_complete_set and biogrid_hgncid