-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dsl2 new test configs #1121
base: dev
Are you sure you want to change the base?
Dsl2 new test configs #1121
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking VERY very good @jbv2 ! Very close, and almost 1:1 ratio with the plan in the issue - good job!
Just a few comments
@@ -0,0 +1,64 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be renamed as just test
, we need to have at least one test that is just that.
skip_qualimap = false | ||
|
||
// Genotyping | ||
genotyping_tool = 'ug' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not yet have bcftools
functionality in there, or does it run by default?
|
||
// Mapping | ||
mapping_tool = 'bowtie2' | ||
convert_inputbam = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't want this to convert back to FASTQ and start straight from bam input going into filtering (i.e., we don't remap) or did you discuss this with Thiseas already?...
Although now I say that, we otherwise not have a test of converting back to FASTQ so maybe it's OK...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correction: you have already specified the convert bam in test_modern,
so this can be removed
convert_inputbam = true |
|
||
// Genome references | ||
fasta_sheet = params.pipelines_testdata_base_path + 'eager/reference/reference_sheet_multiref.csv' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are missing the bedtools coverage stats from this one - so will need to be turned on and the bed input file given
test_malt { includeConfig 'conf/test_malt.config' } | ||
test_krakenuniq { includeConfig 'conf/test_krakenuniq.config' } | ||
test_metaphlan { includeConfig 'conf/test_metaphlan.config' } | ||
test_default { includeConfig 'conf/test_default.config' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above - this test_default
should replace test
and thus be called just test
.
You should remove the old profiles too, except for test_full
.
So test
, test_full
, and all the new ones you've made.
Oh I just remembered: please rename test_nothing
with test_minimal
(I've been overridden by other pipelines sadly, but so we should stay consistent across the community)
No description provided.