Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyrodigal migrate to nf-test #4599

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Pyrodigal migrate to nf-test #4599

merged 5 commits into from
Jan 2, 2024

Conversation

Darcy220606
Copy link
Contributor

@Darcy220606 Darcy220606 commented Dec 14, 2023 •
edited
Loading

This PR updates the Pyrodigal module to nf-test. Thanks to @louperelo 🥇

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@Darcy220606 Darcy220606 requested review from louperelo and a team as code owners December 14, 2023 13:15
louperelo
louperelo approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@louperelo louperelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me and all tests passed.

@Darcy220606 Darcy220606 added this pull request to the merge queue Jan 2, 2024
Merged via the queue into nf-core:master with commit 0e70547 Jan 2, 2024
11 checks passed
@Darcy220606 Darcy220606 deleted the pyrodigal_update branch January 2, 2024 13:21
lrauschning pushed a commit to lrauschning/modules that referenced this pull request Jan 17, 2024
@Darcy220606 @lrauschning
Pyrodigal migrate to nf-test (nf-core#4599)
ee2596d 
* Add main.nf.test

* migrate to nf-test format

* add stub
lrauschning pushed a commit to lrauschning/modules that referenced this pull request Jan 17, 2024
@Darcy220606 @lrauschning
Pyrodigal migrate to nf-test (nf-core#4599)
df88f57 
* Add main.nf.test

* migrate to nf-test format

* add stub
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@Darcy220606 @jennylsmith
Pyrodigal migrate to nf-test (nf-core#4599)
c248f8b 
* Add main.nf.test

* migrate to nf-test format

* add stub
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

@louperelo louperelo louperelo approved these changes

Assignees
No one assigned
Labels
nf-test
Projects
nf-test Migration
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Darcy220606 @mashehu @louperelo