Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump smoothxg to 0.7.2 #4804

Merged
merged 8 commits into from
Jan 25, 2024
Merged

bump smoothxg to 0.7.2 #4804

merged 8 commits into from
Jan 25, 2024

Conversation

subwaystation
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@subwaystation subwaystation requested a review from a team as a code owner January 25, 2024 14:53
@subwaystation subwaystation requested a review from kpadm January 25, 2024 14:53
@subwaystation subwaystation added this pull request to the merge queue Jan 25, 2024
Merged via the queue into nf-core:master with commit bd863b0 Jan 25, 2024
11 checks passed
@subwaystation subwaystation deleted the smoothxg_0.7.2 branch January 25, 2024 15:33
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@subwaystation @jennylsmith
bump smoothxg to 0.7.2 (nf-core#4804)
ef82e04 
* bump smoothxg to 0.7.2

* fix linting errors

* cheat the system

* CI do something please

* CI do something please
@msgr0
Copy link
Contributor

msgr0 commented Jan 15, 2025

smoothxg ver 0.7.2 seems to suffer from this bug (pangenome/pggb#377), fixed in tag 0.8.0 by pangenome/smoothxg#206

Could be possibile to bump smoothxg to tag 0.8.0 ?

@subwaystation
Copy link
Contributor Author

Let's track this here: nf-core/pangenome#215. @msgr0.

@msgr0
Copy link
Contributor

msgr0 commented Jan 15, 2025

Thanks a lot @subwaystation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@kpadm kpadm Awaiting requested review from kpadm kpadm was automatically assigned from nf-core/nf-test

@Zethson Zethson Awaiting requested review from Zethson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subwaystation @msgr0 @FriederikeHanssen