Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve strandedness derivation in rnaseq preprocessing swf #5982

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Jul 16, 2024

I'm porting some improvements we made in rnaseq for strandedness determination to this subworkflow. This is basically defining our own logic and thresholds for setting strandedness, using Salmon statistics, rather than letting Salmon do it internally.

(Note, I'm also moving the rnaseq logic to actually use this subworkflow, after I previously factored the logic out for the riboseq workflow).

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@pinin4fjords pinin4fjords changed the title Improve strandedness devivation Improve strandedness derivation Jul 16, 2024
@pinin4fjords pinin4fjords requested a review from a team as a code owner July 16, 2024 11:13
@pinin4fjords pinin4fjords requested review from LeuThrAsp and maxulysse and removed request for a team and LeuThrAsp July 16, 2024 11:13
@pinin4fjords pinin4fjords changed the title Improve strandedness derivation Improve strandedness derivation in rnaseq preprocessing swf Jul 16, 2024
@pinin4fjords pinin4fjords added this pull request to the merge queue Jul 16, 2024
Merged via the queue into master with commit 0a8d335 Jul 16, 2024
12 checks passed
@pinin4fjords pinin4fjords deleted the improve_strandedness_handling_fastq_prepro branch July 16, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants