Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated test data paths batch 11 #6085

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Aug 2, 2024

PR checklist

Closes #XXX

  • Updated test data paths batch 11
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@SPPearce
Copy link
Contributor

SPPearce commented Aug 2, 2024

The freyja conda module might need an extra dependency pinning to fix the subworkflow failure.

@SPPearce SPPearce added this pull request to the merge queue Aug 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 3, 2024
@GallVp GallVp added this pull request to the merge queue Aug 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 3, 2024
@SPPearce SPPearce added this pull request to the merge queue Aug 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 3, 2024
@GallVp GallVp marked this pull request as draft August 3, 2024 20:27
@GallVp
Copy link
Member Author

GallVp commented Aug 3, 2024

This is failing repeatedly. I'll investigate on my machine and then update it.

@GallVp
Copy link
Member Author

GallVp commented Aug 4, 2024

The issue with freyja/boot andersen-lab/Freyja#167 seems to go away once --depthcutoff is set to an appropriate value. This PR should run successfully now.

@GallVp GallVp marked this pull request as ready for review August 5, 2024 00:02
@GallVp GallVp added this pull request to the merge queue Aug 5, 2024
Merged via the queue into nf-core:master with commit 04e1b23 Aug 5, 2024
38 checks passed
@GallVp GallVp deleted the testpaths/batch11 branch August 5, 2024 22:08
SPPearce pushed a commit that referenced this pull request Aug 6, 2024
* Updated test data paths

* Added --depthcutoff for freyja/boot
github-merge-queue bot pushed a commit that referenced this pull request Aug 23, 2024
* Module: ichorcna/run updated to v0.5.0

Changes:
 - ichorcna no longer has a CLI, so it has been updated to use native R
 - Some additional parameters have been added
 - Requires scStates option in nextflow.config or it crashes

* ichorcna/run gc_wig not optional

* ichorcna/run centromere put above other parameters as it is more important

* ichorcna correct test URLS

* fix meta.yml and change the name to normal_background

* [automated] Fix linting with Prettier

* Update environment to 0.5.0

* createpon test

* Swap to nftest and test 0.5.1 docker

* Remove from tests

* Reset test.yml

* Update output channels and snapshot

* Update snap and meta

* Update PoN

* Add stub and additional asserts to PoN

* change output directory of bclconvert & bcl2fastq (#6112)

* change output directory

* fix linting

* update snapshot

* update lane

* delete environment.yml

* Updated test data paths batch 11 (#6085)

* Updated test data paths

* Added --depthcutoff for freyja/boot

* Updated test data paths batch 17 (#6103)

Updated paths

* Updated test data paths batch 19 (#6105)

* Updated paths

* Updated shapshot for liftlong

* chore(deps): update actions/setup-java digest to 6a0805f (#6114)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Updated test data paths batch 18 (#6104)

* Updated test data paths batch 18

* Fixed instrain version in conda file

* Fixed instrain version in conda file

* Removed db content md5 from snapshot to pass conda test

* Added samtools to instrain env

* Updated snapshot

* Bump chromap version to chromap modules (#6113)

* Bump chromap version to chromap/index

* Bump chromap version to chromap/chromap

* Use nft-bam as suggested in review

* Change how prefix for output index is set to be modifiable

* Add stub, nf-tests and bump version 3.5.5 to deeptools modules (#6109)

* Update deeptools/plotheatmap

* Update deeptols/multibamsummary

* Update plotpca

* Update deeptools/computematrix

* Update deeptools/bamcoverage

* Remove comment

* Update deeptools/plotcorrelation

* Fix c/p error

* Update deeptools/plotfingerprint

* Update nf-core/deeptools

* Add deeptools/plotprofile snapshot

* Simplify tests and fix some issues

* Make lint happy

* Make lint happy

* Reverting plotheatmap meta.yml

* Fix input declaration in meta yaml

* Fix multibamsummary tags

* Fix value type in meta.yml

* Remove pytest for deeptools modules

* Add missing tags in compound test runs

* Fix tyop

* Apply review suggestions

* Update modules/nf-core/deeptools/bamcoverage/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update snapshot for deeptools/bamcoverage after applying review suggestion

* Change how prefix for output index is set to be modifiable

* Revert last commit (wrong branch) :P

---------

Co-authored-by: Simon Pearce <[email protected]>

* Bracken bug fix (#6119)

* Allow for construction of standard database

* Update meta to include standard database

* Fix bug for passing in -l with ext.args

* Full correction

* Update test snapshots

* Add test corresponding to the genus issue

* Revert "Allow for construction of standard database"

This reverts commit 71b800e.

* Revert "Update meta to include standard database"

This reverts commit 1d48333.

* Add nf-test to krakentools/combinekreports (#6120)

add nf-test to krakentools/combinekreports

---------

Co-authored-by: Adam Talbot <[email protected]>
Co-authored-by: Adam Talbot <[email protected]>
Co-authored-by: nf-core-bot <[email protected]>
Co-authored-by: Anabella Trigila <[email protected]>
Co-authored-by: Usman Rashid <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jose Espinosa-Carrasco <[email protected]>
Co-authored-by: Ezra Greenberg <[email protected]>
Co-authored-by: Lili Andersson-Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants