Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcftools_conensus stub section and tests #6219

Merged
merged 7 commits into from
Aug 21, 2024

Conversation

DimitriTernovoj
Copy link
Contributor

Description

The PR adds a stub section along side some tests for the bcftools_consensus module and therefore contributes to the goal of all modules having a stub section (and tests) (#4570). Furthermore I added another component to the input, namely mask. This is an optional input file, but should also be included in the input channel definitions according to the module specifications.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Follow the input/output options guidelines.
  • nf-core modules test <MODULE> --profile singularity

@SPPearce
Copy link
Contributor

You need to remove the pytest files from tests/nf-core/bcftools/consensus, as well as the entry in tests/pytest-config.yml

@DimitriTernovoj DimitriTernovoj requested a review from a team as a code owner August 21, 2024 06:43
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@SPPearce SPPearce added this pull request to the merge queue Aug 21, 2024
Merged via the queue into nf-core:master with commit 7f0ad5e Aug 21, 2024
16 checks passed
@DimitriTernovoj DimitriTernovoj deleted the bcftools_consensus_tests branch August 21, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants