Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDR module #908

Merged
merged 15 commits into from
Oct 30, 2021
Merged

Add IDR module #908

merged 15 commits into from
Oct 30, 2021

Conversation

drpatelh
Copy link
Member

Closes #902

@drpatelh drpatelh marked this pull request as draft October 27, 2021 10:36
@JoseEspinosa JoseEspinosa self-requested a review October 27, 2021 15:24
@JoseEspinosa
Copy link
Member

I think is ready to go @drpatelh . I did not manage to make the test work with bed files, see here some examples, however, seems like the tools has a bug since it always returns something such as an out of index error. I'd guess is expecting more columns... Anyhow, I don't think bed files are widely use for peaks so I will just left this part commented and go ahead.

@JoseEspinosa JoseEspinosa marked this pull request as ready for review October 28, 2021 20:58
Comment on lines 40 to 57
// workflow test_idr_bed {

// // Also tried with these two replicates in bed format from this course
// // (http://jvanheld.github.io/cisreg_course/chip-seq/practical/annotation.html) and did not work
// // http://pedagogix-tagc.univ-mrs.fr/courses/data/ngs/td_chip_seq/all/siGATA_ER_E2_r1_SRX176857_peaks.bed
// // http://pedagogix-tagc.univ-mrs.fr/courses/data/ngs/td_chip_seq/all/siGATA_ER_E2_r2_SRX176859_peaks.bed

// input = [
// //Does not work with the data in test-datasets
// // file(params.test_data['sarscov2']['genome']['test_bed'], checkIfExists: true),
// // file(params.test_data['sarscov2']['genome']['test2_bed'], checkIfExists: true)
// // Also tried to see weather it swallow the same file as narrow and broad mode, but it does not
// // file('https://raw.githubusercontent.com/kundajelab/idr/master/tests/data/peak1', checkIfExists: true),
// // file('https://raw.githubusercontent.com/kundajelab/idr/master/tests/data/peak2', checkIfExists: true)
// ]

// IDR ( input, 'bed', 'test' )
// }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// workflow test_idr_bed {
// // Also tried with these two replicates in bed format from this course
// // (http://jvanheld.github.io/cisreg_course/chip-seq/practical/annotation.html) and did not work
// // http://pedagogix-tagc.univ-mrs.fr/courses/data/ngs/td_chip_seq/all/siGATA_ER_E2_r1_SRX176857_peaks.bed
// // http://pedagogix-tagc.univ-mrs.fr/courses/data/ngs/td_chip_seq/all/siGATA_ER_E2_r2_SRX176859_peaks.bed
// input = [
// //Does not work with the data in test-datasets
// // file(params.test_data['sarscov2']['genome']['test_bed'], checkIfExists: true),
// // file(params.test_data['sarscov2']['genome']['test2_bed'], checkIfExists: true)
// // Also tried to see weather it swallow the same file as narrow and broad mode, but it does not
// // file('https://raw.githubusercontent.com/kundajelab/idr/master/tests/data/peak1', checkIfExists: true),
// // file('https://raw.githubusercontent.com/kundajelab/idr/master/tests/data/peak2', checkIfExists: true)
// ]
// IDR ( input, 'bed', 'test' )
// }

@JoseEspinosa JoseEspinosa merged commit 9fb26ae into nf-core:master Oct 30, 2021
@drpatelh drpatelh deleted the idr branch November 20, 2021 12:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module Adding a new module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: idr
2 participants