Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add filtlong #919

Merged
merged 2 commits into from
Oct 27, 2021
Merged

add filtlong #919

merged 2 commits into from
Oct 27, 2021

Conversation

d4straub
Copy link
Contributor

@d4straub d4straub commented Oct 27, 2021 •
edited
Loading

PR checklist

Closes #832

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd

@d4straub d4straub added new module Adding a new module Ready for Review labels Oct 27, 2021
@d4straub d4straub added this to Ready for Review in Hackathon-October-2021 Oct 27, 2021
FriederikeHanssen
FriederikeHanssen reviewed Oct 27, 2021
View reviewed changes
modules/filtlong/meta.yml
- filtlong:
description: Filtlong is a tool for filtering long reads. It can take a set of long reads and produce a smaller, better subset. It uses both read length (longer is better) and read identity (higher is better) when choosing which reads pass the filter.
homepage: https://anaconda.org/bioconda/filtlong
documentation: None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

FriederikeHanssen
FriederikeHanssen approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4straub d4straub merged commit 12a3f80 into nf-core:master Oct 27, 2021
@d4straub
Copy link
Contributor Author

Thanks!

@d4straub d4straub moved this from Ready for Review to Done - Day 1 in Hackathon-October-2021 Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
new module Adding a new module Ready for Review
Projects
No open projects
Hackathon-October-2021
Done - Day 1
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: filtlong
2 participants
@d4straub @FriederikeHanssen