Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install subworkflows from nf-side #106

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/references branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nf-core pipelines should only use nf-core or local modules and subworkflows

@maxulysse
Copy link
Member Author

nf-core pipelines should only use nf-core or local modules and subworkflows

I know, and it won't be released in this state.
Still I need these functionalities for properly testing and implementing this pipeline properly.

I need things that are not in nf-core yet, and I do need these modules to be patched, as we (maintainers) still need to agree on proper handling on meta maps for references.
So as I need to be able to install subworkflows in pipeline, I am doing this for now, and will push it all to the nf-core/modules repo once done.

@mashehu
Copy link

mashehu commented Mar 26, 2025

Why not make them local first?

@maxulysse
Copy link
Member Author

Why not make them local first?

I want to install these subworkflows and related modules the proper way in other pipelines for POCs.
And I don't want to copy local modules + local subworkflows 3 times everytime I update a single thing.

Consider that the nf-side/modules repo is currently the local versions of modules and subworkflows.
I will only use this before the release, and never merge any of these in any other dev branch in any pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants