Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFCORE_RNASEQ takes values from global scope #1339

Open
adamrtalbot opened this issue Jul 9, 2024 · 0 comments
Open

NFCORE_RNASEQ takes values from global scope #1339

adamrtalbot opened this issue Jul 9, 2024 · 0 comments

Comments

@adamrtalbot
Copy link
Contributor

The workflow NFCORE_RNASEQ doesn't use any parameter and instead takes params values from the global scope instead of using them as inputs:

rnaseq/main.nf

Line 160 in 1af00b9

NFCORE_RNASEQ ()

Instead, it should be tightly scoped and only use things provided in the input block. A simple solution to this might be to use the params object as input:

    //
    // WORKFLOW: Run main workflow
    //
    NFCORE_RNASEQ( params )

This would improve scoping of the workflow and enable easier testing and code portability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant