Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding stubs at all level #1335

Merged
merged 42 commits into from
Aug 21, 2024
Merged

Adding stubs at all level #1335

merged 42 commits into from
Aug 21, 2024

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Jul 3, 2024 •
edited

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1b34d1e

+| ✅ 173 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   7 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-08-21 08:20:39

@maxulysse
Copy link
Member Author

hitting:

  -[nf-core/rnaseq] Pipeline completed successfully with skipped sampl(es)-
  -[nf-core/rnaseq] Please check MultiQC report: 5/5 samples skipped since they failed 10000 trimmed read threshold.-

with stub level pipeline tests...

@maxulysse maxulysse marked this pull request as ready for review July 3, 2024 18:17
@maxulysse
Copy link
Member Author

maxulysse commented Jul 4, 2024 •
edited

Related issues and PRs:

@maxulysse maxulysse mentioned this pull request Jul 8, 2024
Open
pinin4fjords
pinin4fjords previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@pinin4fjords pinin4fjords added this to the 3.15.0 milestone Jul 11, 2024
This was referenced Jul 16, 2024
Closed
Open
@maxulysse
Copy link
Member Author

New error coming out of Picard:

A field field parsed out of a read name was expected to contain an integer and did not. Read name: SRR6357072.6014972. Cause: String 'SRR6357072.6014972' did not start with a parsable number.

@maxulysse maxulysse mentioned this pull request Jul 22, 2024
Open
@maxulysse
Copy link
Member Author

Picard/markduplicates is held back to 3.1.1 due to failing tests at the pipeline level cf #1346

@pinin4fjords pinin4fjords dismissed their stale review August 16, 2024 08:15

Scope has changed since approval

pinin4fjords
pinin4fjords reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good- couple of lagging points to address. I think we should just point the patched module at the older commit, unless you have a reason that won't work.

modules/nf-core/picard/markduplicates/picard-markduplicates.diff Show resolved Hide resolved
tests/default.nf.test Outdated Show resolved Hide resolved
@pinin4fjords pinin4fjords linked an issue Aug 20, 2024 that may be closed by this pull request
Updating picard to 3.2.0 fails pipeline level tests #1346
Open
pinin4fjords
pinin4fjords approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, look forward to seeing the snapshotting stuff in a future PR.

@pinin4fjords
Copy link
Member

Please update the changelog before any merge

@maxulysse
Copy link
Member Author

Please update the changelog before any merge

CHANGELOG updated

@maxulysse maxulysse merged commit ad43736 into nf-core:dev Aug 21, 2024
115 of 120 checks passed
@maxulysse maxulysse deleted the stubs_everywhere branch August 21, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.

Updating picard to 3.2.0 fails pipeline level tests
2 participants
@maxulysse @pinin4fjords