Conversation
…r to resolve linting issues
…regardless of if the user chooses to trim files or not
Co-authored-by: Lili Andersson-Li <64467552+LilyAnderssonLee@users.noreply.github.com>
Co-authored-by: Lili Andersson-Li <64467552+LilyAnderssonLee@users.noreply.github.com>
Collaborator
Author
|
Thank you for the review! I believe I've managed to resolve most of your suggestions -- with the exception of one question back. Please let me know if there's any other questions. Thanks! |
Co-authored-by: Lili Andersson-Li <64467552+LilyAnderssonLee@users.noreply.github.com>
Collaborator
Author
|
Hi @LilyAnderssonLee and @mashehu, I believe we've got all points resolved with some last couple of questions for @mashehu on the other PR, please let us know if you see anything else! Thanks, |
LilyAnderssonLee
approved these changes
Oct 1, 2024
mashehu
approved these changes
Oct 2, 2024
Contributor
mashehu
left a comment
mashehu
left a comment
There was a problem hiding this comment.
Sorry was on vacation.
Looking very nice now! see the pseudo-PR for some smaller comments.
…t as a parameter overrides the default whitelist used by the pipeline
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).