Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using GFF instead of GTF #451

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,27 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## v4.1.0dev

- Add the `--gtf` parameter to allow the user to specify a GFF file as a reference (instead of a GTF file) ([#451](https://github.com/nf-core/scrnaseq/pull/451))

## v4.0.0 - 2025-03-10

- Move `txp2gene` to `reference_genome_options` in schema as it is required by `kb_python` and `alevin` ([434](https://github.com/nf-core/scrnaseq/pull/434))
- Fix of additional path splitting for `txp2gene` ([433](https://github.com/nf-core/scrnaseq/pull/433))
- Move `txp2gene` to `reference_genome_options` in schema as it is required by `kb_python` and `alevin` ([#434](https://github.com/nf-core/scrnaseq/pull/434))
- Fix of additional path splitting for `txp2gene` ([#433](https://github.com/nf-core/scrnaseq/pull/433))
- Add a checker so that `--fb_reference` does not break the pipeline in case `ab` files are not used in `cellranger multi` sub-workflow.
- Fix concatenation of multiple samples into the combined output AnnData ([416](https://github.com/nf-core/scrnaseq/pull/416))
- Make sure STARsolo velocity output is added to the combined output AnnData, if `star_feature = 'Gene Velocyto'` ([417](https://github.com/nf-core/scrnaseq/pull/417))
- Fix concatenation of multiple samples into the combined output AnnData ([#416](https://github.com/nf-core/scrnaseq/pull/416))
- Make sure STARsolo velocity output is added to the combined output AnnData, if `star_feature = 'Gene Velocyto'` ([#417](https://github.com/nf-core/scrnaseq/pull/417))
- Update cellbender module to latest nf-core version ([#419](https://github.com/nf-core/scrnaseq/pull/419/))
- Add profile for gpu processes ([#419](https://github.com/nf-core/scrnaseq/pull/419/))
- Update example usage command in README with valid reference genome parameter ([#339](https://github.com/nf-core/scrnaseq/issues/339))
- Removed `--kb_filter` parameter. Kallisto filtering is triggered by default and can be turned off with `ext.args` ([#421](https://github.com/nf-core/scrnaseq/issues/421))
- Document better that `cellbender` is used for empty drops calling and not the `emptydrops` method (([#420](https://github.com/nf-core/scrnaseq/issues/420)))
- Add `--limitBAMsortRAM` to STARsolo alignment, to make sure BAM sorting memory scales with the task memory ([#430](https://github.com/nf-core/scrnaseq/pull/430))
- Replace local modules for simpleaf, `SIMPLEAF_INDEX` and `SIMPLEAF_QUANT`, with their central modules from nf-core/modules, and update simpleaf subworkflows accordingly. ([424](https://github.com/nf-core/scrnaseq/pull/424))
- Fix of additional path splitting for `txp2gene` ([433](https://github.com/nf-core/scrnaseq/pull/433))
- Update documents related to `simpleaf`, `alevin`, `salmon`, and `alevin-fry` for consistency.([424](https://github.com/nf-core/scrnaseq/pull/424))
- Rename the default aligner from `alevin` to `simpleaf` for consistency.([424](https://github.com/nf-core/scrnaseq/pull/424))
- Update the `mtx_to_h5ad` template for `simpleaf` to start from the h5ad file generated by simpleaf.([424](https://github.com/nf-core/scrnaseq/pull/424))
- Upgrade alevinqc from 1.12.1 to 1.18.0 to match the latest output file structure of simpleaf.([424](https://github.com/nf-core/scrnaseq/pull/424))
- Replace local modules for simpleaf, `SIMPLEAF_INDEX` and `SIMPLEAF_QUANT`, with their central modules from nf-core/modules, and update simpleaf subworkflows accordingly. ([#424](https://github.com/nf-core/scrnaseq/pull/424))
- Fix of additional path splitting for `txp2gene` ([#433](https://github.com/nf-core/scrnaseq/pull/433))
- Update documents related to `simpleaf`, `alevin`, `salmon`, and `alevin-fry` for consistency.([#424](https://github.com/nf-core/scrnaseq/pull/424))
- Rename the default aligner from `alevin` to `simpleaf` for consistency.([#424](https://github.com/nf-core/scrnaseq/pull/424))
- Update the `mtx_to_h5ad` template for `simpleaf` to start from the h5ad file generated by simpleaf.([#424](https://github.com/nf-core/scrnaseq/pull/424))
- Upgrade alevinqc from 1.12.1 to 1.18.0 to match the latest output file structure of simpleaf.([#424](https://github.com/nf-core/scrnaseq/pull/424))

## v3.0.0 - 2024-12-09

Expand Down
10 changes: 10 additions & 0 deletions conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ process {
]
}

withName: 'GFFREAD' {
ext.args = '--keep-exon-attrs -F -T'
publishDir = [
path: { "${params.outdir}/reference_genome" },
mode: params.publish_dir_mode,
enabled : params.save_reference,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]
}

if (!params.skip_cellbender) {
withName: 'CELLBENDER_REMOVEBACKGROUND' {
publishDir = [
Expand Down
2 changes: 2 additions & 0 deletions docs/output.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ The pipeline also possess a subworkflow imported from scdownstream to perform fi
- `extract_transcriptome`
- When supplied with a `--fasta` genome fasta, this contains the extracted transcriptome
- The GTF file supplied with `--gtf` is used to extract the transcriptome positions appropriately
- `*.gtf`
- If only a `.gff` file was provided, the `.gtf` file generated by converting the `.gff` file will be saved here if using `--save-reference`.

**Output directory: `results/${params.aligner}/mtx_conversions`**

Expand Down
4 changes: 2 additions & 2 deletions docs/usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ you have to create a new cellranger-arc index ([see here](https://support.10xgen
more information)

If you decide to create a cellranger-arc index, then you need to create a config file to generate the index. The pipeline
can do this autmatically for you if you provide a `--fasta`, `--gtf`, and an optional `--motif` file. However, you can
can do this autmatically for you if you provide a `--fasta`, `--gtf` or `--gff`, and an optional `--motif` file. However, you can
also decide to provide your own config file with `--cellrangerarc_config`, then you also have to specify with `--cellrangerarc_reference`
the reference genome name that you have used and stated as _genome:_ in your config file.

Expand Down Expand Up @@ -279,7 +279,7 @@ The `sample` column must match the corresponding entry in the main samplesheet.
#### Additional reference data

- Cellranger multi needs a reference for **GEX and VDJ analysis**. They are calculated on the fly given the reference
files (`--fasta` and `--gtf`) provided, but users can also provide their own with: `--cellranger_index`
files (`--fasta`, and `--gtf` or `--gff`) provided, but users can also provide their own with: `--cellranger_index`
and `--cellranger_vdj_index`, for GEX and VDJ, respectively.

> When running cellranger multi, without any VDJ data, users can also skip VDJ automated ref building with: `--skip_cellrangermulti_vdjref`.
Expand Down
2 changes: 1 addition & 1 deletion modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
},
"gffread": {
"branch": "master",
"git_sha": "b1b959609bda44341120aed1766329909f54b8d0",
"git_sha": "81880787133db07d9b4c1febd152c090eb8325dc",
"installed_by": ["modules"]
},
"gunzip": {
Expand Down
6 changes: 3 additions & 3 deletions modules/nf-core/gffread/environment.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

49 changes: 37 additions & 12 deletions modules/nf-core/gffread/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

69 changes: 54 additions & 15 deletions modules/nf-core/gffread/meta.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading