Change simpleaf protocol name from 10xv4 to 10xv4-3p #452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this moment, running the pipeline on samples with
10XV4
protocol and simpleaf aligner fails. As can be seen in the list of supported chemistries in simpleaf, the chemistry10xv4
does not exist, they only have10xv4-3p
available. This issue was not flagged in tests, as the test dataset is only using10xv2
protocol.This PR only changes the protocol name for this particular chemistry, but perhaps the whole list should be changed to more closely follow the list of available chemistries of simpleaf?
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).