-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kraken2 phylogenetic assignment subworkflow #47
Open
ctuni
wants to merge
53
commits into
nf-core:dev
Choose a base branch
from
ctuni:feature/kraken2
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 31 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
036daf0
first commit with kraken2 module
ctuni e7c1e71
added a database to the config
ctuni 4549e1a
added kraken2 param to schema
ctuni c158510
readded modules
ctuni d058ccf
fixed kraken2 name
ctuni e942664
added missing kraken2 options
ctuni 033df6e
fixed something in the linting
ctuni c5edd67
added output to multiqc
ctuni 6c55393
changed the kraken2 channels
ctuni 59c4108
removed kraken2 from mutiqc for now
ctuni bf8eaa2
added kraken2 reports to the multqc channel
ctuni a9aba3e
trying other methods to creae the multiqc files channel
ctuni 07bd918
trying to pass kraken2 report to multiqc
ctuni f4dc19a
why is multiqc not working?
ctuni d430a27
why is multiqc not working?
ctuni 3e0d357
ugh
ctuni b6c0d88
removed kraken2 from multiqc files
ctuni ff8efdd
updated schema
ctuni 5b602dd
Merge branch 'dev' into feature/kraken2
ctuni 7b2f665
fixing some things
ctuni ca597f7
changed schema version
ctuni 400a76b
trying to unbreak things
ctuni 4906699
added prettier
ctuni 54ce903
further unbreaking things
ctuni a3ef27b
re-updated schema
ctuni 4b7aaad
prettier
ctuni 0192830
forgot to change changelog
ctuni a6f5c6b
added krona plots to the emit block and added check for uncompressed …
ctuni d8c31ec
fixed typo
ctuni 7e41b19
several improvements
ctuni 82c68e7
prettier
ctuni 3e9b674
updated citations
ctuni dbb92c1
Update docs/output.md
ctuni 0324ead
updated output
ctuni f1759e1
updated output
ctuni dd9e07c
Merge branch 'dev' into feature/kraken2
ctuni 828abd6
added kraken2 reports to multiqc
ctuni 31c1f82
Merge branch 'feature/kraken2' of https://github.com/ctuni/seqinspect…
ctuni 3a22a9e
schema
ctuni 5a4ce9c
Merge branch 'dev' into feature/kraken2
ctuni 34b766d
Merge branch 'feature/kraken2' of https://github.com/ctuni/seqinspect…
ctuni b698d41
prettier
ctuni 6dd4859
Update workflows/seqinspector.nf
ctuni 07dee47
disabled the publish of the taxonomy file
ctuni abea138
Merge branch 'feature/kraken2' of https://github.com/ctuni/seqinspect…
ctuni a60d573
removed default database for a null one
ctuni 2488887
added test kraken2 database to the test configs
ctuni e28397a
fixed typo
ctuni 9d8f631
miseq test is failing
ctuni 5d1a15b
miseq test is failing
ctuni 4729ada
promethion test is failing
ctuni bb8e3b0
novaseq test is failing
ctuni 758ce12
novaseq test is failing
ctuni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure you want to output the kraken db, because it's size can be huge (depending on the selected one) and also it has been previously downloaded by the user, so already in user's device? You may want to use the storeDir in case you want to store the db and reuse it for later without the need of publishing it in the output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean! I could create a patch to the UNTAR module to add the storeDir directive, that would also need some changes to the config but it can be done.
In any case, to avoid unnecessary waste of space by saving the uncompressed database, the pipeline works differently if the user provides a gzipped database or an uncompressed one. If the pipeline is gzipped, the
UNTAR
module uncompresses it and uses it, but by default, it won't save the uncompressed database if the user provided a compressed database.The outputting of the uncompressed kraken2 db is turned off by default by the
params.save_uncompressed_k2db
, which is set asfalse
. On themodules.config
file this is read by theenable
declaration.If the database is uncompressed, and the user passes a path to the
kraken2_db
param, theUNTAR
module is not called; the database is simply used and remains in the user's original directory.