Skip to content

Commit

Permalink
Merge pull request #1066 from nf-core/dev
Browse files Browse the repository at this point in the history
`dev` -> `master` for v1.14 release
  • Loading branch information
ewels authored May 11, 2021
2 parents d0a6649 + 193bc8e commit 7721f37
Show file tree
Hide file tree
Showing 85 changed files with 1,932 additions and 1,136 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/create-lint-wf.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
name: Create a pipeline and lint it
on: [push, pull_request]

# Uncomment if we need an edge release of Nextflow again
# env: NXF_EDGE: 1

jobs:
MakeTestWorkflow:
runs-on: ubuntu-latest
env:
NXF_VER: 21.03.0-edge
steps:
- uses: actions/checkout@v2
name: Check out source-code repository

- name: Set up Python 3.7
- name: Set up Python 3.8
uses: actions/setup-python@v1
with:
python-version: 3.7
python-version: 3.8

- name: Install python dependencies
run: |
Expand Down
32 changes: 32 additions & 0 deletions .github/workflows/push_dockerhub_dev.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: nf-core Docker push (dev)
# This builds the docker image and pushes it to DockerHub
# Runs on nf-core repo releases and push event to 'dev' branch (PR merges)
on:
push:
branches:
- dev

jobs:
push_dockerhub:
name: Push new Docker image to Docker Hub (dev)
runs-on: ubuntu-latest
# Only run for the nf-core repo, for releases and merged PRs
if: ${{ github.repository == 'nf-core/tools'}}
env:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_PASS: ${{ secrets.DOCKERHUB_PASS }}
strategy:
matrix:
image: [base, tools]
steps:
- name: Check out tools code
uses: actions/checkout@v2

- name: Build new docker image
run: docker build --no-cache . -t nfcore/${{ matrix.image }}:dev -f ${{ matrix.image }}.Dockerfile

- name: Push Docker image to DockerHub (dev)
run: |
echo "$DOCKERHUB_PASS" | docker login -u "$DOCKERHUB_USERNAME" --password-stdin
docker push nfcore/${{ matrix.image }}:dev
32 changes: 32 additions & 0 deletions .github/workflows/push_dockerhub_release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: nf-core Docker push (release)
# This builds the docker image and pushes it to DockerHub
# Runs on nf-core repo releases and push event to 'dev' branch (PR merges)
on:
release:
types: [published]

jobs:
push_dockerhub:
name: Push new Docker image to Docker Hub (release)
runs-on: ubuntu-latest
# Only run for the nf-core repo, for releases and merged PRs
if: ${{ github.repository == 'nf-core/tools' }}
env:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_PASS: ${{ secrets.DOCKERHUB_PASS }}
strategy:
matrix:
image: [base, tools]
steps:
- name: Check out code
uses: actions/checkout@v2

- name: Build new docker image
run: docker build --no-cache . -t nfcore/${{ matrix.image }}:latest -f ${{ matrix.image }}.Dockerfile

- name: Push Docker image to DockerHub (release)
run: |
echo "$DOCKERHUB_PASS" | docker login -u "$DOCKERHUB_USERNAME" --password-stdin
docker push nfcore/${{ matrix.image }}:latest
docker tag nfcore/${{ matrix.image }}:latest nf-core/${{ matrix.image }}:${{ github.event.release.tag_name }}
docker push nfcore/${{ matrix.image }}:${{ github.event.release.tag_name }}
7 changes: 4 additions & 3 deletions .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,15 @@ on:
paths:
- "**.py"

# Uncomment if we need an edge release of Nextflow again
# env: NXF_EDGE: 1

jobs:
pytest:
runs-on: ubuntu-latest
env:
NXF_VER: 21.03.0-edge
strategy:
matrix:
python-version: [3.6, 3.7, 3.8]
python-version: [3.6, 3.7, 3.8, 3.9]

steps:
- uses: actions/checkout@v2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sync.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ on:
types: [published]
workflow_dispatch:

env:
NXF_VER: 21.03.0-edge
# Uncomment if we need an edge release of Nextflow again
# env: NXF_EDGE: 1

jobs:
get-pipelines:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: nf-core/tools API docs
name: nf-core/tools dev API docs
on:
push:
branches: [master, dev]
branches: [dev]

jobs:
api-docs:
Expand All @@ -26,18 +26,14 @@ jobs:
- name: Build HTML docs
run: make --directory ./docs/api html

- name: Push docs to api-doc branch
- name: Sync dev docs
if: github.repository == 'nf-core/tools'
run: |
git checkout --orphan api-doc
git rm -r --cache .
rm .gitignore
git config user.email "[email protected]"
git config user.name "nf-core-bot"
git add docs
git commit --message "nf-core/tools docs build
$GITHUB_REF - $GITHUB_SHA
"
git remote add nf-core https://github.com/nf-core/tools.git
git push --force --set-upstream nf-core api-doc
uses: SamKirkland/[email protected]
with:
server: ${{ secrets.ftp_server }}
username: ${{ secrets.ftp_username}}
password: ${{ secrets.ftp_password }}
local-dir: './docs/api/_build/html/'
server-dir: ${{ secrets.ftp_server_dir }}/dev/
protocol: ${{ secrets.ftp_protocol }}
port: ${{ secrets.ftp_port }}
42 changes: 42 additions & 0 deletions .github/workflows/tools-api-docs-release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: nf-core/tools release API docs
on:
release:
types: [published]

jobs:
api-docs:
name: Build & push Sphinx API docs
runs-on: ubuntu-18.04
strategy:
matrix:
dir: [latest, $GITHUB_REF]

steps:
- name: Check out source-code repository
uses: actions/checkout@v2

- name: Set up Python 3.7
uses: actions/setup-python@v1
with:
python-version: 3.7

- name: Install python dependencies
run: |
pip install --upgrade pip
pip install -r ./docs/api/requirements.txt
pip install .
- name: Build HTML docs
run: make --directory ./docs/api html

- name: Sync release docs
if: github.repository == 'nf-core/tools'
uses: SamKirkland/[email protected]
with:
server: ${{ secrets.ftp_server }}
username: ${{ secrets.ftp_username}}
password: ${{ secrets.ftp_password }}
local-dir: './docs/api/_build/html/'
server-dir: ${{ secrets.ftp_server_dir }}/${{ matrix.dir }}/
protocol: ${{ secrets.ftp_protocol }}
port: ${{ secrets.ftp_port }}
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -114,3 +114,4 @@ ENV/
.idea
pip-wheel-metadata
.vscode
.*.sw?
51 changes: 51 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,56 @@
# nf-core/tools: Changelog

## [v1.14 - Brass Chicken :chicken:](https://github.com/nf-core/tools/releases/tag/1.14) - [2021-05-11]

### Template

* Fixed an issue regarding explicit disabling of unused container engines [[#972](https://github.com/nf-core/tools/pull/972)]
* Removed trailing slash from `params.igenomes_base` to yield valid s3 paths (previous paths work with Nextflow but not aws cli)
* Added a timestamp to the trace + timetime + report + dag filenames to fix overwrite issue on AWS
* Rewrite the `params_summary_log()` function to properly ignore unset params and have nicer formatting [[#971](https://github.com/nf-core/tools/issues/971)]
* Fix overly strict `--max_time` formatting regex in template schema [[#973](https://github.com/nf-core/tools/issues/973)]
* Convert `d` to `day` in the `cleanParameters` function to make Duration objects like `2d` pass the validation [[#858](https://github.com/nf-core/tools/issues/858)]
* Added nextflow version to quick start section and adjusted `nf-core bump-version` [[#1032](https://github.com/nf-core/tools/issues/1032)]
* Use latest stable Nextflow version `21.04.0` for CI tests instead of the `-edge` release

### Download

* Fix bug in `nf-core download` where image names were getting a hyphen in `nf-core` which was breaking things.
* Extensive new interactive prompts for all command line flags [[#1027](https://github.com/nf-core/tools/issues/1027)]
* It is now recommended to run `nf-core download` without any cli options and follow prompts (though flags can be used to run non-interactively if you wish)
* New helper code to set `$NXF_SINGULARITY_CACHEDIR` and add to `.bashrc` if desired [[#1027](https://github.com/nf-core/tools/issues/1027)]

### Launch

* Strip values from `nf-core launch` web response which are `False` and have no default in the schema [[#976](https://github.com/nf-core/tools/issues/976)]
* Improve API caching code when polling the website, fixes noisy log message when waiting for a response [[#1029](https://github.com/nf-core/tools/issues/1029)]
* New interactive prompts for pipeline name [[#1027](https://github.com/nf-core/tools/issues/1027)]

### Modules

* Added `tool_name_underscore` to the module template to allow TOOL_SUBTOOL in `main.nf` [[#1011](https://github.com/nf-core/tools/issues/1011)]
* Added `--conda-name` flag to `nf-core modules create` command to allow sidestepping questionary [[#988](https://github.com/nf-core/tools/issues/988)]
* Extended `nf-core modules lint` functionality to check tags in `test.yml` and to look for a entry in the `pytest_software.yml` file
* Update `modules` commands to use new test tag format `tool/subtool`
* New modules lint test comparing the `functions.nf` file to the template version
* Modules installed from alternative sources are put in folders based on the name of the source repository

### Linting

* Fix bug in nf-core lint config skipping for the `nextflow_config` test [[#1019](https://github.com/nf-core/tools/issues/1019)]
* New `-k`/`--key` cli option for `nf-core lint` to allow you to run only named lint tests, for faster local debugging
* Merge markers lint test - ignore binary files, allow config to ignore specific files [[#1040](https://github.com/nf-core/tools/pull/1040)]
* New lint test to check if all defined pipeline parameters are mentioned in `main.nf` [[#1038](https://github.com/nf-core/tools/issues/1038)]
* Added fix to remove warnings about params that get converted from camelCase to camel-case [[#1035](https://github.com/nf-core/tools/issues/1035)]
* Added pipeline schema lint checks for missing parameter description and parameters outside of groups [[#1017](https://github.com/nf-core/tools/issues/1017)]

### General

* Try to fix the fix for the automated sync when we submit too many PRs at once [[#970](https://github.com/nf-core/tools/issues/970)]
* Rewrite how the tools documentation is deployed to the website, to allow multiple versions
* Created new Docker image for the tools cli package - see installation docs for details [[#917](https://github.com/nf-core/tools/issues/917)]
* Ignore permission errors for setting up requests cache directories to allow starting with an invalid or read-only `HOME` directory

## [v1.13.3 - Copper Crocodile Resurrection :crocodile:](https://github.com/nf-core/tools/releases/tag/1.13.2) - [2021-03-24]

* Running tests twice with `nf-core modules create-test-yml` to catch unreproducible md5 sums [[#890](https://github.com/nf-core/tools/issues/890)]
Expand Down
Loading

0 comments on commit 7721f37

Please sign in to comment.