-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nf-core download: Create container image symlinks so images are still found, even if registry config diverges. #2768
nf-core download: Create container image symlinks so images are still found, even if registry config diverges. #2768
Conversation
692663e
to
98c760f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
aacde33
to
453afca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! Just had a couple minor questions for you
…ibraries (registries).
…e presumably unlikely, names including the registry are now consistently always symlinks.
…-core download tests.
Co-authored-by: Adrien Coulier <[email protected]>
08de383
to
dceb7b3
Compare
This addition to
nf-core download
addresses #2751, #2644, demultiplex#164 and multiple Slack issues: 1,2,3.Dropping the hardcoded registry from the modules in favour of the flexible config parameters
apptainer.registry
,docker.registry
,podman.registry
andsingularity.registry
was initiated by Seqera, but so far Nextflow has not received concordant updates to also resolve to images downloaded from alternative registries as a fallback.The code in this PR creates a bunch of symlinks to the downloaded images to ensure that they are found nonetheless. To ensure that it is possible to run the pipelines without symlinks by setting
docker.registry
orapptainer.registry
to empty strings at runtime, the original registry is not preserved any more when downloading. This harbours a small risk of naming collisions, however, due to the symlinks it is anyway not possible to use the same$NXF_CACHE_DIR
for pipelines using different containers with identical image names pulled from different registries.Additionally, this PR modifies the
pytest.yml
Github Action such that the new tests are run at all, because they require Singularity.PR checklist
CHANGELOG.md
is updateddocs
is updated