Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.0-draft.1 #60

Open
wants to merge 49 commits into
base: release
Choose a base branch
from
Open

1.0.0-draft.1 #60

wants to merge 49 commits into from

Conversation

kMutagene
Copy link
Member

@kMutagene kMutagene commented Mar 7, 2025 •
edited
Loading

This PR includes all changes for the first draft of the stable 1.0 release. The main goals are harmonizing mapping and profile documents, fixing issues that resulted in incorrect crates, and overall clarifications and improvements to readability.

Overview of the changes:

kMutagene and others added 30 commits September 12, 2024 09:22
@kMutagene
Add DOI badge
f61c28c
@floWetzels
Update README.md
6d46241
@HLWeil
Merge pull request #34 from nfdi4plants/new-readme
a240280 
Added mapping file and small description to README
@floWetzels
Added DefinedTerm Profile
2abeff4
@HLWeil
Merge pull request #35 from nfdi4plants/defined-term-profile
01c9335 
Added DefinedTerm Profile
@floWetzels
Updated title from headline to name in profile
004c0ea
@floWetzels
Updated title from headline to name in mapping
dc13bfc
@floWetzels
Added explanation for title-name mapping
30ec70d
@floWetzels
Merge pull request #36 from nfdi4plants/title_to_name
736c8cc 
Updated title from headline to name in profile
@kMutagene
#38: Add mandatory license property to investigation profile
c7ccc42
@kMutagene
#38: Make datePublished mandatory
d620755
@kMutagene
#38: Make description mandatory
2b7921f
@kMutagene
#39: make object/result optional
6d7debb
@kMutagene
LabProcess: make agent optional #41
db1eb78
@kMutagene
PropertyValue: make value optional #40
bac8ecf
@kMutagene
fix some typos
bbf9a05
@HLWeil
Merge pull request #42 from nfdi4plants/harmonize
8d72f27 
Harmonize with Scaffold specs
@floWetzels
fixed comment property in Person
a340ffd
@floWetzels
Update isa_ro_crate.md
9c5183a
@floWetzels
fixed overwrite of previous changes...
c17c428
@floWetzels
updated hasPart description of investigation
0c1bc26
@HLWeil
Merge pull request #47 from nfdi4plants/Allow-Assays-in-Investigation
1450b1a 
Allow Assays in Investigation
@HLWeil
add links to doi and pubmedid mapping
d5f36ab
@HLWeil
Merge pull request #46 from nfdi4plants/Bugfixes-and-Updates-for-Scho…
a6bbceb 
…larlyArticle

Bugfixes and Updates for ScholarlyArticle
@floWetzels @HLWeil
Fragment Selectors in profile description
fdc70c5
@floWetzels @HLWeil
Fragment selectors in mapping
7cf0737
@HLWeil
add explication for relationships of data files and fragments
d2ba994
@floWetzels
Merge pull request #28 from nfdi4plants/datafragment
e95b974 
Data Fragment Selectors
@kMutagene
Add title and description to assay profile #49
416c0e8
@HLWeil
update mapping file to current state of specification
7b42833
HLWeil and others added 19 commits March 3, 2025 11:19
@HLWeil
small adjustments to mapping according to PR discussion
275b77f
@kMutagene
Merge pull request #50 from nfdi4plants/harmonize
b354589 
Add title and description to assay profile
@kMutagene
small clarification
8959f7a
@kMutagene
sync order of mapping and profile, add comment profile, fix some props
80c3402
@floWetzels
removed derivesFrom from Sample
1f67859
@kMutagene
Merge pull request #54 from nfdi4plants/Sample-fix
bee52b5 
Fix inconsistency between profile and mapping for Sample
@kMutagene
clarify ISA comment to string conversion
e49980a
@floWetzels
added sorting requirement for process inputs and outputs
2c6e64d
@kMutagene
Merge pull request #56 from nfdi4plants/process_input_sorting
20874e2 
added sorting requirement for process inputs and outputs
@kMutagene
Clarification of mapping and usage of PropertyValue
ed7134f
@kMutagene
split property value profile into multiple instances for the special …
c4b0762 
…cases of parameter, factor, characteristic, and component
@kMutagene
must -> MUST, internal profile links where possible
2fd0d64
@kMutagene
fix formatting and copy errors
4e6995d
@kMutagene
should -> must use additional type for Key-Value-Unit Triples
b90490f
@kMutagene
typo/ordering fixes
6f1f87c
@kMutagene
Merge pull request #53 from nfdi4plants/harmonize
fa3ba70 
sync mapping and profile, improve formatting
@kMutagene
add TOC
d4cb44c
@kMutagene
Merge pull request #59 from nfdi4plants/harmonize
e502d03 
add TOC
@kMutagene
update version
418ca3e
@kMutagene kMutagene requested review from HLWeil and floWetzels March 7, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HLWeil HLWeil Awaiting requested review from HLWeil

@floWetzels floWetzels Awaiting requested review from floWetzels

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kMutagene @floWetzels @HLWeil