Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to import def pfr data #109

Merged

Conversation

felixblochwitz
Copy link
Contributor

This PR addresses issue #108

It adds the option to specify s_type as def for the functions import_seasonal_pfr and import_weekly_pfr by adding them as valid inputs to the function _validate_pfr_inputs.

Data for defensive stats is available since 2018 (same starting point as other categories) here: https://github.com/nflverse/nflverse-data/releases/tag/pfr_advstats. Thus, loading this data should work as intended.

@alecglen alecglen changed the base branch from main to v0.3.3 September 17, 2024 13:50
Copy link
Collaborator

@alecglen alecglen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @felixblochwitz!

@alecglen
Copy link
Collaborator

I changed the PR's base branch from main to v0.3.3 so it will merge in with the next package version being released this week. If you merge that branch's commits into your branch, then the test suite should pass and we'll get this merged.

@felixblochwitz
Copy link
Contributor Author

I changed the PR's base branch from main to v0.3.3 so it will merge in with the next package version being released this week. If you merge that branch's commits into your branch, then the test suite should pass and we'll get this merged.

Thanks for your comment. I think I merged the commits from the v0.3.3 branch successfully into my branch (hope I did this correctly, it's my first time contributing to something public). If you need me to do anything else, just let me know.

@alecglen
Copy link
Collaborator

Perfect - thanks again! 👍

@alecglen alecglen merged commit 16423da into nflverse:v0.3.3 Sep 17, 2024
21 checks passed
@alecglen alecglen linked an issue Sep 17, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] <Add ability to download def pfr data>
2 participants