Fix DataFrame indexing - import_ids() #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanillies
changed the title
|
Thanks for the improvement @brendanillies, and sorry it took so long to get back to! This will be added in the newest version. I had a few small suggestions to make and didn't want to bother you with them a year later, so I made a different branch which you can see linked above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time doing this so bear with me!
Function
import_ids()was using an incorrect DataFrame indexing method - namely specifyingsetvs.list. Added type conversion as well as a default case of returned columnsret_columnsto remove multiple lines of redefining thedfvariable. Also added passing test cases around the change and added test case caching to be ignored.