Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column data types to import_ids() #88

Merged

Conversation

justinrobinson1020
Copy link

Provides data types to the read_csv function in import_ids(). Previously, pandas parsed some numeric ids as floats adding trailing zeros that required removal. New data types are:

  • birthdate is parsed as a datetime64
  • age is parsed as a Float64
  • draft_year, draft_round, draft_pick, draft_ovr, height, weight, and db_season are parsed as Int64
  • all other fields including numeric ids are parsed as strings

@alecglen alecglen changed the base branch from main to v1.0.0 September 17, 2024 02:23
@alecglen
Copy link
Collaborator

Good idea, thanks @justinrobinson1020! I'm going to merge this to the v1.0 release branch since it's technically a breaking change.

@alecglen alecglen merged commit e94511b into nflverse:v1.0.0 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants