summarise target share and air yards share correctly (#413)

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: nflfastR
 Title: Functions to Efficiently Access NFL Play by Play Data
-Version: 4.5.1.9001
+Version: 4.5.1.9002
 Authors@R: 
     c(person(given = "Sebastian",
              family = "Carl",

NEWS.md

@@ -1,6 +1,7 @@
 # nflfastR (development version)
 
 - internal function `get_pbp_nfl()` now uses `ifelse()` instead of `dplyr::if_else()` to handle some null-checking, fixes bug found in 2022_21_CIN_KC match. (v4.5.1.9001)
+- The function `calculate_player_stats()` now summarises target share and air yards share correctly when called with argument `weekly = FALSE` (#413)
 
 # nflfastR 4.5.1
 

R/aggregate_game_stats.R

@@ -553,6 +553,12 @@ calculate_player_stats <- function(pbp, weekly = FALSE) {
   # if user doesn't want week-by-week input, aggregate the whole df
   if (isFALSE(weekly)) {
     player_df <- player_df %>%
+      # helper variables to summarise targetshare and air yard share
+      # because targets and air yards summarise first
+      dplyr::mutate(
+        tgts = .data$targets,
+        rec_air_yds = .data$receiving_air_yards
+      ) %>%
       dplyr::group_by(.data$player_id) %>%
       dplyr::summarise(
         player_name = custom_mode(.data$player_name),
@@ -598,8 +604,8 @@ calculate_player_stats <- function(pbp, weekly = FALSE) {
         receiving_epa = dplyr::if_else(all(is.na(.data$receiving_epa)), NA_real_, sum(.data$receiving_epa, na.rm = TRUE)),
         receiving_2pt_conversions = sum(.data$receiving_2pt_conversions),
         racr = .data$receiving_yards / .data$receiving_air_yards,
-        target_share = dplyr::if_else(all(is.na(.data$target_share)), NA_real_, mean(.data$target_share, na.rm = TRUE)),
-        air_yards_share = dplyr::if_else(all(is.na(.data$air_yards_share)), NA_real_, mean(.data$air_yards_share, na.rm = TRUE)),
+        target_share = dplyr::if_else(all(is.na(.data$target_share)), NA_real_, sum(.data$tgts, na.rm = TRUE) / sum(.data$tgts / .data$target_share, na.rm = TRUE)),
+        air_yards_share = dplyr::if_else(all(is.na(.data$air_yards_share)), NA_real_, sum(.data$rec_air_yds, na.rm = TRUE) / sum(.data$rec_air_yds / .data$air_yards_share, na.rm = TRUE)),
         wopr = 1.5 * .data$target_share + 0.7 * .data$air_yards_share,
 
         # special teams

vignettes/beginners_guide.Rmd

@@ -440,7 +440,7 @@ offense %>%
   # tier lines
   ggplot2::geom_abline(slope = -1.5, intercept = (4:-3)/10, alpha = .2) +
   # nflplotR magic
-  nflplotR::geom_mean_lines(aes(h_var = off_epa, v_var = def_epa)) +
+  nflplotR::geom_mean_lines(aes(y0 = off_epa, x0 = def_epa)) +
   nflplotR::geom_nfl_logos(aes(team_abbr = team), width = 0.07, alpha = 0.7) +
   ggplot2::labs(
     x = "Offense EPA/play",

vignettes/nflfastR.Rmd

@@ -145,7 +145,7 @@ offense %>%
   dplyr::inner_join(defense, by = "team") %>%
   ggplot2::ggplot(aes(x = off_epa, y = def_epa)) +
   ggplot2::geom_abline(slope = -1.5, intercept = c(.4, .3, .2, .1, 0, -.1, -.2, -.3), alpha = .2) +
-  nflplotR::geom_mean_lines(aes(h_var = off_epa, v_var = def_epa)) +
+  nflplotR::geom_mean_lines(aes(y0 = off_epa, x0 = def_epa)) +
   nflplotR::geom_nfl_logos(aes(team_abbr = team), width = 0.07, alpha = 0.7) +
   ggplot2::labs(
     x = "Offense EPA/play",