Skip to content

Commit

Permalink
update news and cran comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mrcaseb committed Nov 4, 2022
1 parent 70f379a commit 149d3a8
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 11 deletions.
18 changes: 11 additions & 7 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
# nflfastR 4.5.0

## New (experimental) functions
* Added new function `calculate_player_stats_def()` that aggregates defensive player stats either at game level or overall. (#288)
* The situation report `nflverse_sitrep` which is an alias of the already available `report()`
* Added new function `calculate_player_stats_kicking()` that aggregates player stats for field goals and extra points at game level or overall. (#381)
* Added new function `calculate_series_conversion_rates()` that computes series conversion and series result rates at a game level or season level. (#393)

## Bugfixes and Minor Improvements

* Internal change to `calculate_player_stats()` that reflects new nflverse data infrastructure.
* `calculate_player_stats()` now unifies player names and joins the following player information via `nflreadr::load_players()`:
- `player_display_name` - Full name of the player
- `position` - Position of the player
- `position_group` - Position group of the player
- `headshot_url` - URL to a player headshot image
* Added new function `calculate_player_stats_def()` that aggregates defensive player stats either at game level or overall. (#288) v4.4.0.9006
* Make data work in 2022 (hopefully)
* Fix Amon-Ra St. Brown breaking the name parser
* import/export `nflverse_sitrep`
* Add gsis_id patch to `clean_pbp()`. (v4.4.0.9009)
* `calculate_player_stats_def()` failed in situations where play-by-play data is missing certain stats. (#382) (v4.4.0.9010)
* Spot-fixing `calculate_player_stats()` for NA names. (v4.4.0.9011)
* Added new function `calculate_player_stats_kicking()` that aggregates player stats for field goals and extra points at game level or overall. (v4.4.0.9012)
* Added new function `calculate_series_conversion_rates()` that computes series conversion and series result rates at a game level or season level. (v4.4.0.9013)
* Add gsis_id patch to `clean_pbp()`.
* `calculate_player_stats_def()` failed in situations where play-by-play data is missing certain stats. (#382)
* Spot-fixing `calculate_player_stats()` for `NA` names.

# nflfastR 4.4.0

Expand Down
5 changes: 2 additions & 3 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,15 @@

This is a minor release that
* fixes bugs
* removes deprecated arguments
* adds a new function
* add new functions

## R CMD check results

0 errors | 0 warnings | 0 notes

## revdepcheck results

We checked 2 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
We checked 3 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages
1 change: 0 additions & 1 deletion nflfastR.Rproj
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ StripTrailingWhitespace: Yes

BuildType: Package
PackageUseDevtools: Yes
PackageCleanBeforeInstall: Yes
PackageInstallArgs: --no-multiarch --with-keep.source
PackageRoxygenize: rd,collate,namespace

Expand Down

0 comments on commit 149d3a8

Please sign in to comment.