Skip to content

Commit

Permalink
Merge pull request #292 from nflverse/release-v430
Browse files Browse the repository at this point in the history
Release v430
  • Loading branch information
mrcaseb authored Oct 6, 2021
2 parents 0f6b908 + 0842919 commit 4b3229c
Show file tree
Hide file tree
Showing 6 changed files with 42 additions and 31 deletions.
2 changes: 2 additions & 0 deletions CRAN-RELEASE
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
This package was submitted to CRAN on 2021-10-06.
Once it is accepted, delete this file and tag the release (commit f21fd38).
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: nflfastR
Title: Functions to Efficiently Access NFL Play by Play Data
Version: 4.2.0.9008
Version: 4.3.0
Authors@R:
c(person(given = "Sebastian",
family = "Carl",
Expand Down
13 changes: 9 additions & 4 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
# nflfastR (development version)
# nflfastR 4.3.0

* Fixed a minor bug in the console output of `update_db()`
* Add nflreadr to dependecies and drop lubridate and magrittr dependency
## Minor Changes

* Add [nflreadr](https://nflreadr.nflverse.com/) to dependecies and drop lubridate and magrittr dependency
* The functions `load_pbp()` and `load_player_stats()` now call `nflreadr::load_pbp()` and `nflreadr::load_player_stats()` respectively. Therefore the argument `qs` has been deprecated in both functions. It will be removed in a future release. Running `load_player_stats()` without any argument will now return player stats of the current season only (the default in `nflreadr`).
* The deprecated arguments `source` and `pp` in the functions `fast_scraper_*()` and `build_nflfastR_pbp()` have been removed
* Added the variables `racr` ("Receiver Air Conversion Ratio"), `target_share`, `air_yards_share`, `wopr` ("Weighted Opportunity Rating") and `pacr` ("Passing Air Conversion Ratio") to the output of `calculate_player_stats()`
* Fix for a handful of missing `receiver` names (#270)
* Added the function `report()` which will be used by the maintainers to help users debug their problems (#274).

## Bug Fixes

* Fixed a minor bug in the console output of `update_db()`
* Fix for a handful of missing `receiver` names (#270)
* Fixed bug with missing `return_team` on interception return touchdowns (#275)
* Fixed a rare bug where an internal object wasn't predefined (#272)

Expand Down
26 changes: 3 additions & 23 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,9 @@

This is a minor release that
* fixes bugs
* fixes a broken example

## Test environments

* local R installation, R 4.1.0
* Debian Linux, R-devel, clang, ISO-8859-15 locale
* Debian Linux, R-devel, GCC
* Debian Linux, R-devel, GCC, no long double
* Debian Linux, R-patched, GCC
* Debian Linux, R-release, GCC
* Fedora Linux, R-devel, clang, gfortran
* Fedora Linux, R-devel, GCC
* CentOS 8, stock R from EPEL
* macOS 10.13.6 High Sierra, R-release, brew
* macOS 10.13.6 High Sierra, R-release, CRAN's setup
* Ubuntu Linux 20.04.1 LTS, R-devel, GCC
* Ubuntu Linux 20.04.1 LTS, R-release, GCC
* Ubuntu Linux 20.04.1 LTS, R-devel with rchk
* Windows Server 2008 R2 SP1, R-devel, 32/64 bit
* Windows Server 2008 R2 SP1, R-oldrel, 32/64 bit
* Windows Server 2008 R2 SP1, R-patched, 32/64 bit
* Windows Server 2008 R2 SP1, R-release, 32/64 bit
* win-builder (devel)
* removes deprecated arguments
* changes some dependencies
* adds a new function

## R CMD check results

Expand Down
3 changes: 1 addition & 2 deletions man/nflfastR-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 26 additions & 1 deletion pkgdown/_pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ home:
navbar:
structure:
left: [home, intro, reference, news, articles, tutorials]
right: [data, stats, games, twitter, discord, github]
right: [data, stats, games, twitter, discord, github, more]
components:
twitter:
icon: "fab fa-twitter fa-lg"
Expand Down Expand Up @@ -80,6 +80,30 @@ navbar:
href: https://www.opensourcefootball.com/posts/2020-09-28-nflfastr-ep-wp-and-cp-models/
- text: Open Source Football
href: https://www.opensourcefootball.com/
more:
text: "Packages & More"
menu:
- text: "nflverse Packages"
- text: nflfastR
href: https://www.nflfastr.com
- text: nflseedR
href: https://nflseedr.com
- text: nfl4th
href: https://www.nfl4th.com
- text: nflreadr
href: https://nflreadr.nflverse.com/
- text: nflplotR
href: https://nflplotr.nflverse.com/
- text: "Open Source Football"
href: https://www.opensourcefootball.com
- text: "nflverse Data"
- text: nflverse GitHub
href: https://github.com/nflverse
- text: espnscrapeR Package
href: https://jthomasmock.github.io/espnscrapeR/
- text: ffverse
- text: "ffverse.com"
href: https://www.ffverse.com
reference:
- title: Main Functions
contents:
Expand All @@ -94,6 +118,7 @@ reference:
- calculate_expected_points
- calculate_win_probability
- calculate_player_stats
- report
- title: Documentation
contents:
- nflfastR-package
Expand Down

0 comments on commit 4b3229c

Please sign in to comment.