-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scrambles for older years #468
Conversation
@mrcaseb I think this is ready except for the test failing because it changes the output and no longer matches expected output (eg scramble, rush, pass etc change on some plays) |
I can update test expectation but will be out of town until Sunday |
because some scrambles changed with this PR
Seems like MacOS isn't happy with the new expectation. I will review later. Also I introduced some new "global variable" warnings that could be fixed in this PR as well |
if unix/windows fail now, we have to round to 3 significant digits instead of 4
Tests still failing? |
|
Still fails even with a pretty lenient tolerance. I am confused. It's like it's ignoring the tolerance param. |
it wasn't saved correctly anyways as the initial "round_double_to_digits" converted all double variables to character and I saved this as expectation
also round to 3 significant digits because tests failed on Mac in the 4th digit
Still a work in progress. The older years of data are a mess in the NFL pbp